Go back button is disabled HTML about:addons
Categories
(Toolkit :: Add-ons Manager, defect, P1)
Tracking
()
People
(Reporter: mstriemer, Assigned: mstriemer)
References
Details
Attachments
(1 file)
47 bytes,
text/x-phabricator-request
|
jcristau
:
approval-mozilla-beta+
|
Details | Review |
The go back button can be disabled when it should not be disabled.
I was able to reproduce this in my Nightly about a week ago, but have never been able to reproduce it in my local build.
STR
- Open about:addons (with HTML views enabled)
- Very quickly upon load open a detail page
- Click the "Go back" button (navigating back won't cause the bug)
- Open another detail page
Expected results: The Go back button is enabled.
Actual results: The Go back button is disabled.
Calling gViewController.updateCommand("cmd_back")
will fix the button, but only until the next view load.
Assignee | ||
Comment 1•5 years ago
|
||
Looks like my first STR aren't quite right.
STR
- Enable extensions.htmlaboutaddons.enabled
- Open about:addons
- Open the Extension list
- Close about:addons
- Open about:addons (should now load the extension list)
- Open an extension detail page
- Click the "Go back" button
- Open another extension detail page
Things to note:
- Navigating using the history directly (two-finger swipe or browser back button) does not cause the bug (until you click the "Go back" button).
- Switching list views appears to fix it
Assignee | ||
Comment 2•5 years ago
|
||
Pushed by mstriemer@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a55afb034677 Update commands on show in HTML about:addons r=mixedpuppy,kmag
Comment 4•5 years ago
|
||
bugherder |
Updated•5 years ago
|
This issue is verified as fixed on Firefox 69.0a1 (20190605095225) under Win 7 64-bit and Mac OS X 10.14.1 with the STR from Comment1.
Assignee | ||
Comment 6•5 years ago
|
||
Comment on attachment 9069013 [details]
Bug 1551213 - Update commands on show in HTML about:addons r?mixedpuppy
Beta/Release Uplift Approval Request
- User impact if declined: In some cases the "Go back" button within the HTML about:addons page can become incorrectly disabled.
- Is this code covered by automated tests?: Yes
- Has the fix been verified in Nightly?: Yes
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): Small change with test coverage.
- String changes made/needed:
Comment 7•5 years ago
•
|
||
Comment on attachment 9069013 [details]
Bug 1551213 - Update commands on show in HTML about:addons r?mixedpuppy
1-line fix for html about:addons, approved for 68.0b9
Comment 8•5 years ago
|
||
bugherder uplift |
This issue is verified as fixed on Firefox 68.0b9 (20190610153228) under Win 7 64-bit and Mac OS X 10.14.1 with the STR from comment1.
Description
•