Closed Bug 1551213 Opened 11 months ago Closed 10 months ago

Go back button is disabled HTML about:addons

Categories

(Toolkit :: Add-ons Manager, defect, P1)

defect

Tracking

()

VERIFIED FIXED
mozilla69
Tracking Status
firefox68 --- verified
firefox69 --- verified

People

(Reporter: mstriemer, Assigned: mstriemer)

References

Details

Attachments

(1 file)

The go back button can be disabled when it should not be disabled.

I was able to reproduce this in my Nightly about a week ago, but have never been able to reproduce it in my local build.

STR

  1. Open about:addons (with HTML views enabled)
  2. Very quickly upon load open a detail page
  3. Click the "Go back" button (navigating back won't cause the bug)
  4. Open another detail page

Expected results: The Go back button is enabled.
Actual results: The Go back button is disabled.

Calling gViewController.updateCommand("cmd_back") will fix the button, but only until the next view load.

Looks like my first STR aren't quite right.

STR

  1. Enable extensions.htmlaboutaddons.enabled
  2. Open about:addons
  3. Open the Extension list
  4. Close about:addons
  5. Open about:addons (should now load the extension list)
  6. Open an extension detail page
  7. Click the "Go back" button
  8. Open another extension detail page

Things to note:

  • Navigating using the history directly (two-finger swipe or browser back button) does not cause the bug (until you click the "Go back" button).
  • Switching list views appears to fix it
Pushed by mstriemer@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a55afb034677
Update commands on show in HTML about:addons r=mixedpuppy,kmag
Status: NEW → RESOLVED
Closed: 10 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla69
Assignee: nobody → mstriemer

This issue is verified as fixed on Firefox 69.0a1 (20190605095225) under Win 7 64-bit and Mac OS X 10.14.1 with the STR from Comment1.

Status: RESOLVED → VERIFIED

Comment on attachment 9069013 [details]
Bug 1551213 - Update commands on show in HTML about:addons r?mixedpuppy

Beta/Release Uplift Approval Request

  • User impact if declined: In some cases the "Go back" button within the HTML about:addons page can become incorrectly disabled.
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Small change with test coverage.
  • String changes made/needed:
Attachment #9069013 - Flags: approval-mozilla-beta?

Comment on attachment 9069013 [details]
Bug 1551213 - Update commands on show in HTML about:addons r?mixedpuppy

1-line fix for html about:addons, approved for 68.0b9

Attachment #9069013 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

This issue is verified as fixed on Firefox 68.0b9 (20190610153228) under Win 7 64-bit and Mac OS X 10.14.1 with the STR from comment1.

You need to log in before you can comment on or make changes to this bug.