Closed Bug 1551316 Opened 7 months ago Closed 5 months ago

Add pc.restartIce() method.

Categories

(Core :: WebRTC, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
mozilla70
Tracking Status
firefox68 --- wontfix
firefox69 --- wontfix
firefox70 --- fixed

People

(Reporter: jib, Assigned: jib)

References

(Blocks 1 open bug, )

Details

(Keywords: dev-doc-complete)

Attachments

(2 files)

Add proposed restartIce() method to RTCPeerConnection behind a pref, to meet commitment.

Assignee: nobody → jib
Depends on: 1551740

There are some r+ patches which didn't land and no activity in this bug for 2 weeks.
:jib, could you have a look please?
For more information, please visit auto_nag documentation.

Flags: needinfo?(jib)

Since these patches contain wpt tests (which would get upstreamed), I'm holding off until a June 11th webrtc interim where this feature will be discussed.

Flags: needinfo?(jib)
Attachment #9064573 - Attachment description: Bug 1551316 - Add pc.restartIce() method behind a pref. → Bug 1551316 - Add pc.restartIce() method.

Spec PR merged, so this can land without pref.

Summary: Add pc.restartIce() method behind a pref → Add pc.restartIce() method.

Try to increase number of test chunks.

Depending on what's opening files, you could also try adding "restart-after" to the metadata for some webrtc tests.

Docs:

A key ``restart-after`` which can be set to any value to indicate that
   the runner should restart the browser after running this test (e.g. to
   clear out unwanted state).

Bumping the number of chunks appears not to have worked (though there's no stack, so I've re-run it a few times to get one just in case):

[task 2019-07-17T03:37:26.321Z] 03:37:26     INFO - IOError on command, setting status to CRASH
[task 2019-07-17T03:37:26.538Z] 03:37:26     INFO - TEST-UNEXPECTED-CRASH | /webrtc/RTCPeerConnection-setRemoteDescription-rollback.html | expected OK

The newly added test is 10 tests prior to this crash. Will try a restart-after somewhere in the middle, thanks!

Trying restart-after.

Blocks: 1566857

:jib - when the time comes, please be sure to also add dev-doc-needed to any follow-up bugs around enabling this on various channels, or by default. Thanks!

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/17897 for changes under testing/web-platform/tests
Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.

This is already enabled, not behind a pref. Riding the trains.

Status: NEW → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla70

Since the status are different for nightly and release, what's the status for beta?
For more information, please visit auto_nag documentation.

Upstream PR merged

Documentation is up to date:

Firefox 70 for developers was already updated by Chris.

You need to log in before you can comment on or make changes to this bug.