1551316 - Add pc.restartIce() method.

Status: RESOLVED FIXED

(Core :: WebRTC, enhancement, P2)

Description

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Add proposed restartIce() method to RTCPeerConnection behind a pref, to meet commitment.

Comment 1

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Attachment: Bug 1551316 - Add pc.restartIce() method.

Comment 2

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Attachment: Bug 1551316 - Add restartIce wpt tests.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

There are some r+ patches which didn't land and no activity in this bug for 2 weeks.
:jib, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 4

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Since these patches contain wpt tests (which would get upstreamed), I'm holding off until a June 11th webrtc interim where this feature will be discussed.

Comment 5

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Spec PR merged, so this can land without pref.

Comment 6

[Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)]

Would increasing the number of test chunks help with the fd issue?

https://searchfox.org/mozilla-central/source/taskcluster/ci/test/web-platform.yml#47

Comment 7

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Added https://github.com/w3c/webrtc-pc/pull/2231 for latest change.

Comment 8

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Try to increase number of test chunks.

Comment 9

[Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)]

Depending on what's opening files, you could also try adding "restart-after" to the metadata for some webrtc tests.

Docs:

A key ``restart-after`` which can be set to any value to indicate that
   the runner should restart the browser after running this test (e.g. to
   clear out unwanted state).

Comment 10

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Bumping the number of chunks appears not to have worked (though there's no stack, so I've re-run it a few times to get one just in case):

[task 2019-07-17T03:37:26.321Z] 03:37:26     INFO - IOError on command, setting status to CRASH
[task 2019-07-17T03:37:26.538Z] 03:37:26     INFO - TEST-UNEXPECTED-CRASH | /webrtc/RTCPeerConnection-setRemoteDescription-rollback.html | expected OK

The newly added test is 10 tests prior to this crash. Will try a restart-after somewhere in the middle, thanks!

Comment 11

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Trying restart-after.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7e047766fccd
Add pc.restartIce() method. r=bwc,smaug
https://hg.mozilla.org/integration/autoland/rev/1e8389cdefd3
Add restartIce wpt tests. r=bwc

Comment 13

[Eric Shepherd [:sheppy]]

:jib - when the time comes, please be sure to also add dev-doc-needed to any follow-up bugs around enabling this on various channels, or by default. Thanks!

Comment 14

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/17897 for changes under testing/web-platform/tests

Comment 15

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.

Comment 16

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

This is already enabled, not behind a pref. Riding the trains.

Comment 17

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/7e047766fccd
https://hg.mozilla.org/mozilla-central/rev/1e8389cdefd3

Comment 18

[BugBot [:suhaib / :marco/ :calixte]]

Since the status are different for nightly and release, what's the status for beta?
For more information, please visit auto_nag documentation.

Comment 19

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged

Comment 20

[Eric Shepherd [:sheppy]]

Documentation is up to date:

• RTCPeerConnection.restartIce()
• BCD update PR has been submitted to set the compatibility versions for Firefox and Chrome

Firefox 70 for developers was already updated by Chris.