1551353 - Profiler does not capture screenshots when WebRender is enabled

Status: RESOLVED FIXED

(Core :: Gecko Profiler, defect, P2)

Description

[Denis Palmeiro [:denispal]]

I experienced this on Windows 10, but I did not try the other platforms. I cannot collect any screenshots when WebRender is enabled, even if the Renderer thread is being profiled.

Comment 1

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Screenshots are not implemented on all platforms yet. Adding this one to the meta bug 1444449.

Comment 2

[Barret Rennie [:barret] (they/them)]

:gerald they are implemented on all platforms. This is a regression.

Comment 3

[Barret Rennie [:barret] (they/them)]

Profiler screenshots are working correctly in Nightly on both macOS and Linux. Only Windows seems to be an issue.

Comment 4

[Barret Rennie [:barret] (they/them)]

Attachment: Bug 1551353 - Correctly map PBOs for readback on GLES r?kvark

The implementation of Device::map_pbo_for_readback on GLES (e.g., Windows
with ANGLE) was using the incorrect enumeration value when attempting to map
the buffer into memory.

Comment 5

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

My mistake, didn't notice bug 1444434. Thank you Barret for handling this.

(Nit: I believe the bug that introduced the regression should be under "Regressed by", see https://wiki.mozilla.org/BMO/UserGuide/BugFields#regressed_by .)

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a2fe99cb693a
Correctly map PBOs for readback on GLES r=kvark

Comment 7

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/a2fe99cb693a