1551452 - The Firefox Tab will crash when revoking Temporary Permissions for screen sharing

Status: RESOLVED DUPLICATE of bug 1550955

(Core :: WebRTC, defect, P2)

Description

[Rares Doghi, Desktop QA]

[Affected versions]:
Nightly 68.0a1

[Affected platforms]:
Platforms: ALL

Steps :

1. Launch the Firefox browser and reach https://mozilla.github.io/webrtc-landing/gum_test.html
2. Click the Window Button and Allow screen Sharing of a Screen.
3. Click the Site Information Panel and Revoke the Temporary Allowed Permissions.

Expected Results :
The Page should stop sharing the screen, And the Success text should be displayed.

Actual Results :
The Firefox Tab crashes with the "Gah your tab just crashed" text.

I tried to do a mozregression but it seems theres not enough data for a more accurate find.
Last GOOD: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=579cc975268f03bcc335f099a25215b87836a4ef&tochange=414f37afbe07fd8e5164daf8fa50b38cb64c83ec
First BAD: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=04bd7929b499d25fc538e516fc3de1aa6e9d79dc&tochange=414f37afbe07fd8e5164daf8fa50b38cb64c83ec

Comment 1

[Rares Doghi, Desktop QA]

Attachment: 2019-05-14_11h42_05.mp4

Comment 2

[Dan Minor [:dminor]]

This reproduces easily on a Linux system. The crash is caused by a use after free.

Comment 3

[Dan Minor [:dminor]]

It appears that this crash is only reachable from chrome and not from content, so perhaps it doesn't need to be a sec bug after all.

Comment 4

[Andrew McCreight [:mccr8]]

It should probably still be a sec bug even though it is from chrome, but I think it can be sec-moderate.

Comment 5

[Andrew McCreight [:mccr8]]

Bug 1550955 is another crash involving stopping sharing. I don't know if it is the same issue or not.

Comment 6

[Dan Minor [:dminor]]

Looks like the same issue to me. Thanks for pointing that out!