1551455 - [WIN] - Acer - FFX 62+ not displaying languagePack in about:addons language section

Status: VERIFIED FIXED

(Firefox :: Distributions, defect, P1)

Description

[Cristian Fogel [:cfogel]]

Attachment: Screenshot_26.png

Affected versions

• 67.0

Affected platforms

• Windows 10, Windows 8.1

Steps to reproduce

1. Install a Firefox (62+ version)- set up for Acer distribution;
2. Set up the language pack as per instructions in the document bellow;
3. Perform update;
4. Access about:addons

*see this link for additional details;

Expected result

• New section displayed under Plugins;

Actual result

• The Languages section is not displayed;
• After the restart, warning that the version is not compatible is displayed;

Regression range

• issues started to reproduce with updates from Firefox 62;

Additional notes

• attached screenshot with console log, xpi file renamed;
• trying to redo the setup with versions prior to this, ex 58.0 does not exhibit this issue;

Comment 1

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Attachment: Screenshot_27.png

Hello! Opening Firefox 65.0 on the first run after following the steps from comment 0, the following messages (see screenshot) are displayed in the browser console:
1557823848286 addons.xpi-utils WARN Add-on [e-mail] is not correctly signed.
1557823848292 addons.xpi-utils WARN addMetadata: Add-on [e-mail] is invalid: Error: Extension [e-mail] is not correctly signed(resource://gre/modules/addons/XPIDatabase.jsm:2343:17) JS Stack trace: [e-mail]:2343:17
[e-mail]:2686:21
[e-mail]:2581:34
[e-mail]:2159:25
[e-mail]:203:12
[e-mail]:652:5
[e-mail]:805:9
[e-mail]:2775:5
[e-mail]:66:9

Comment 2

[Pascal Chevrel:pascalc]

Mike, could you investigate and triage wrt our upcoming 67 release next week? Thanks

Comment 3

[Camelia Badau [:cbadau], Desktop Test Engineering]

I installed Firefox 66.0.5 "de" and "en-US" x64 builds (- set up for Acer distribution) -> I set up the language pack as per instructions in the document from Description -> Perform update (Firefox is updated to 67.0) and then access about:addons -> The Languages section is displayed.
It seems that for builds updated from Firefox 66.0.5, Languages section is correctly displayed.

I've tested on Windows 7 x64 and Windows 10 x64.

Comment 4

[Mike Kaply [:mkaply]]

Summary of what is happening:

Firefox 62 tries to install the addon from the distribution directory, but it fails because of the signature problem.
Even though the install failed, we set the pref:

[e-mail]

to true

Because this pref is set to true, we will never try to install the distribution langpacks again.

Comment 5

[Mike Kaply [:mkaply]]

This bug should block 67. We need to do a one time reset of distro addon prefs.

Comment 6

[Mike Kaply [:mkaply]]

Also we need to fix the bug here:

https://searchfox.org/mozilla-central/source/toolkit/mozapps/extensions/internal/XPIInstall.jsm#3340

We should not set this pref if the install didn't succeed.

Comment 7

[Mike Kaply [:mkaply]]

Attachment: Bug 1551455 - Don't check distro install status again.

Comment 8

[Mike Kaply [:mkaply]]

[Tracking Requested - why for this release]: This is as major blocker for Acer preloads.

They are already in the store, so we have to figure out how to fix this in an update.

Comment 9

[Mike Kaply [:mkaply]]

Attachment: Bug 1551455 - Reinstall distribution language packs.

Comment 10

[Pascal Chevrel:pascalc]

Mike, this patch is r+, what is preventing the landing and uplift request?

Comment 11

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Worth asking if this is needed in ESR repo or not.

Comment 12

[Mike Kaply [:mkaply]]

Comment on attachment 9065409 [details]
Bug 1551455 - Reinstall distribution language packs.

Beta/Release Uplift Approval Request

• User impact if declined: Acer preloads lose their language packs.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Steps are in bug, QA is familiar
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Only affects this very specific case (locales that are installed via distribution)
• String changes made/needed:

Comment 13

[Mike Kaply [:mkaply]]

This is not needed on ESR.

Comment 14

[Pascal Chevrel:pascalc]

Comment on attachment 9065409 [details]
Bug 1551455 - Reinstall distribution language packs.

Release blocker, uplift approved for RC2.

Comment 15

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/releases/mozilla-release/rev/2a7896ba9aa5

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/296ca33d9a0e
Reinstall distribution language packs. r=kmag

Comment 17

[Cristian Fogel [:cfogel]]

Fix verified with 67.0 - build 2.
For a detailed report, check the test run in this link.

Comment 18

[Cristian Fogel [:cfogel]]

Updating status for bug.

Comment 19

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/296ca33d9a0e

Comment 20

[Firefox Bug Husbandry Bot]

Please specify a root cause for this bug. See :tmaity for more information.