1551541 - HTML about:addons should show permissions prompt when enabling sideloaded extensions

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, defect, P1)

Description

[Luca Greco [:rpl] [:luca] [:lgreco]]

When a sideloaded extension is enabled from about:addons, it should show a permission prompt (if the extension does have permissions), and the extension should be actually enabled when (and if) the user has accepted the permission prompt.

In the XUL about:addons page this behavior is implemented in the cmd_enableItem's doCommand method, and so we should refactor and move that logic from extensions.js into aboutaddonsCommon.js (as we did for other logic we need to share between the XUL and HMTL about:addons pages) and then ensure that aboutaddons.js also use the shared logic to show the permissions prompt in the above scenario.

This behavior is tested by browser_extension_sideloading.js, which is one of the tests that fails when the HTML about:addons page is enabled by default (Bug 1551490),
and so we should be sure that it completes successfully with the HTML about:addons page enabled by default as part of this issue.

Comment 1

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1551541 - HTML about:addons should show permissions prompt when enabling sideloaded extensions. r?mstriemer!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1978cee5e963
HTML about:addons should show permissions prompt when enabling sideloaded extensions. r=mstriemer

Comment 3

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/1978cee5e963

Comment 4

[Rob Wu [:robwu]]

Comment on attachment 9064759 [details]
Bug 1551541 - HTML about:addons should show permissions prompt when enabling sideloaded extensions. r?mstriemer!

Beta/Release Uplift Approval Request

• User impact if declined: Users are not prompted for extension permissions when they enable a sideloaded add-on via the HTML about:addons page. Consequently they may enable a sideloaded add-on without being informed about its (powerful) capabilities.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Patch consists of UI logic (reusing existing logic) and is well-covered by unit tests. The patch has baked for a week without any reported regressions or intermittent failures.
• String changes made/needed: none

Comment 5

[Julien Cristau [:jcristau]]

Comment on attachment 9064759 [details]
Bug 1551541 - HTML about:addons should show permissions prompt when enabling sideloaded extensions. r?mstriemer!

fix for html about:addons, approved for 68.0b8

Comment 6

[Oana Pop-Rus]

https://hg.mozilla.org/releases/mozilla-beta/rev/9bce7f0a4e57

Comment 7

[Madalin Cotetiu]

In the uplift request there is stated that there is no need of manual qa. If that is true can you please mark this as "qe-verify-"?