1551579 - [Inactive CSS] Display a warning when resize is used incorrectly

Status: RESOLVED FIXED

(DevTools :: Inspector: Rules, enhancement, P3)

Description

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Only elements with overflow other than visible, and optionally replaced elements such as images, videos, and iframes:

[
  "resize",
]

[This property] doesn't have an effect because it only applies to elements with overflow other than visible, and optionally replaced elements such as images, videos, and iframes.

Comment 1

[Sebastian Zartner [:sebo]]

Attachment: Bug 1551579 - [devtools] Handle 'resize' property in inactive CSS. r=#devtools-reviewers.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7e5d5b2318b1
[devtools] Handle 'resize' property in inactive CSS. r=devtools-reviewers,fluent-reviewers,nchevobbe,bolsson.

Comment 3

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/7e5d5b2318b1

Comment 4

[Francesco Lodolo [:flod]]

Forwarding my comment from Phabricator. We have a short window to fix these without a new ID (maybe until Monday-Tuesday of next week), otherwise fixes will need to land with new IDs and code changes.

Not sure about the strings in this patch. Could someone help me understand?

<strong>{ $property }</strong> has no effect on this element since it can only 
be applied to elements with an overflow value other than visible and on certain 
replaced elements, such as textareas.

The way I understand it, the property works only on "elements with overflow≠visible" or "certain replaced elements like textareas". If that's the case, it's confusing that we say can only be applied TO (a) and then and ON (b) (should be still and TO).

Try setting <strong>overflow</strong> to a value other than <strong>visible</strong> 
or to a replaced element supporting it.

Based on the first string, the first part makes sense (set overflow to something other than visible), but what does it mean to set overflow to a replaced element?

Would these be better?

<strong>{ $property }</strong> has no effect on this element since it can only 
be applied to elements with an overflow value other than visible, and to certain 
replaced elements, such as textareas.

Try setting <strong>overflow</strong> to a value other than <strong>visible</strong> 
or target a replaced element supporting it.

Comment 5

[Sebastian Zartner [:sebo]]

(In reply to Francesco Lodolo [:flod] from comment #4)

Forwarding my comment from Phabricator. We have a short window to fix these without a new ID (maybe until Monday-Tuesday of next week), otherwise fixes will need to land with new IDs and code changes.

I'm at a conference right now, so I didn't read your comment earlier, sorry! I'll get back today, so I can fix things over the weekend.

<strong>{ $property }</strong> has no effect on this element since it can only 
be applied to elements with an overflow value other than visible, and to certain 
replaced elements, such as textareas.

Try setting <strong>overflow</strong> to a value other than <strong>visible</strong> 
or target a replaced element supporting it.

Yeah, both notes and suggestions make total sense. I'll provide a patch and set you as reviewer, Francesco.
(Keeping the ni there for now, so I don't forget about it when I'm back home.)

Sebastian

Comment 6

[Francesco Lodolo [:flod]]

(In reply to Sebastian Zartner [:sebo] from comment #5)

I'm at a conference right now, so I didn't read your comment earlier, sorry! I'll get back today, so I can fix things over the weekend.

Let me do the patch and set you as reviewer, that might speed things up.