1551580 - [Inactive CSS] Display a warning when float related properties are used incorrectly.

Status: RESOLVED FIXED

(DevTools :: Inspector: Rules, enhancement, P3)

Description

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Only non-flex and non-grid items:

[
  "float",
]

[This property] doesn't have an effect because it cannot be used on grid or flex items.

---

Only block-level elements, floats, regions and pages:

[
  "clear",
]

[This property] doesn't have an effect because it only applies to block level elements, floats regions and pages. Try adding properties like display:block or float:left

---

Only floats:

[
  "float-offset",
  "shape-image-threshold",
  "shape-margin",
  "shape-outside",
]

[This property] doesn't have an effect because it only applies to floated elements. Try adding properties like float:left

Comment 1

[Sebastian Zartner [:sebo]]

Attachment: Bug 1551580 - [devtools] Handle float-related issues in inactive CSS. r=#devtools-reviewers.

The clear property currently only applies to block-Level elements, not to floats, regions, or pages, because the related CSS Page Floats Module (https://www.w3.org/TR/css-page-floats-3/) is not implemented yet.
For the same reason, we don't check float-offset and float-defer at the moment.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2eb99e54f529
[devtools] Handle float-related issues in inactive CSS. r=devtools-reviewers,fluent-reviewers,flod,nchevobbe.

Comment 3

[tszentpeteri]

https://hg.mozilla.org/mozilla-central/rev/2eb99e54f529