1551593 - [socket process] MOZ_CRASH(Transition error) at ipc/glue/ProtocolUtils.cpp:269

Status: RESOLVED FIXED

(Core :: Networking, defect, P2)

Description

[Kershaw Chang [:kershaw]]

Hit this when running test netwerk/test/unit/test_websocket_offline.js.

Stacktrace:
Hit MOZ_CRASH(Transition error) at /Users/changkershaw/work/central/ipc/glue/ProtocolUtils.cpp:269
#01: mozilla::net::PDNSRequestChild::SendLookupCompleted(mozilla::net::DNSRequestResponse const&)[/Users/changkershaw/work/central/obj-x86_64-apple-darwin17.7.0/dist/NightlyDebug.app/Contents/MacOS/XUL +0x9c7612]
#02: mozilla::net::DNSRequestHandler::DoAsyncResolve(nsTSubstring<char> const&, mozilla::OriginAttributes const&, unsigned int)[/Users/changkershaw/work/central/obj-x86_64-apple-darwin17.7.0/dist/NightlyDebug.app/Contents/MacOS/XUL +0x3272ed]
#03: mozilla::net::SocketProcessChild::AllocPDNSRequestChild(nsTString<char> const&, mozilla::OriginAttributes const&, unsigned int const&)[/Users/changkershaw/work/central/obj-x86_64-apple-darwin17.7.0/dist/NightlyDebug.app/Contents/MacOS/XUL +0x790a9a]
#04: mozilla::net::PSocketProcessChild::OnMessageReceived(IPC::Message const&)[/Users/changkershaw/work/central/obj-x86_64-apple-darwin17.7.0/dist/NightlyDebug.app/Contents/MacOS/XUL +0xbea60a]
#05: mozilla::ipc::MessageChannel::DispatchAsyncMessage(IPC::Message const&)[/Users/changkershaw/work/central/obj-x86_64-apple-darwin17.7.0/dist/NightlyDebug.app/Contents/MacOS/XUL +0x89bb19]
#06: mozilla::ipc::MessageChannel::DispatchMessage(IPC::Message&&)[/Users/changkershaw/work/central/obj-x86_64-apple-darwin17.7.0/dist/NightlyDebug.app/Contents/MacOS/XUL +0x899d94]
#07: mozilla::ipc::MessageChannel::RunMessage(mozilla::ipc::MessageChannel::MessageTask&)[/Users/changkershaw/work/central/obj-x86_64-apple-darwin17.7.0/dist/NightlyDebug.app/Contents/MacOS/XUL +0x89a960]

Comment 1

[Kershaw Chang [:kershaw]]

This crash is caused by sending IPC message before the LivenessState becomes Start.
We can't call DoAsyncResolve in SocketProcessChild::AllocPDNSRequestChild, since the LivenessState turns to Start after AllocPDNSRequestChild.

Comment 2

[Kershaw Chang [:kershaw]]

Attachment: Bug 1551593 - Call DoAsyncResolve after LivenessState is Start

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:kershaw, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 4

[Kershaw Chang [:kershaw]]

https://hg.mozilla.org/projects/larch/rev/6e0f8402198aa37bd095300d01fd65ff992b1d22
Landed.