Closed Bug 1551609 Opened 5 months ago Closed 5 months ago

Make printUtils.js consistent about internal/external naming

Categories

(Toolkit :: Printing, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla68
Tracking Status
firefox68 --- fixed

People

(Reporter: jwatt, Assigned: jwatt)

Details

Attachments

(1 file)

The inconsistency of the use of a leading "_" in the names in printUtils.js to indicate internal names makes in more difficult to know what is being used external to that file.

Pushed by jwatt@jwatt.org:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8e07958a53a2
Make printUtils.js consistent about internal/external naming. r=mconley
Pushed by jwatt@jwatt.org:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d8d0020e4b9e
Follow-up to mark PrintUtils.enterPrintPreview internal. r=mconley

Mike - ni'ing you since I took the liberty of fixing another function that I missed in the original patch. Just so you're aware.

Flags: needinfo?(mconley)
Status: NEW → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68

So noted, thanks!

Flags: needinfo?(mconley)
You need to log in before you can comment on or make changes to this bug.