Audit telemetry probes for memory usage
Categories
(Core :: Graphics: WebRender, task, P3)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox69 | --- | fixed |
People
(Reporter: kats, Assigned: kats)
References
Details
Attachments
(2 files)
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
2.34 KB,
text/plain
|
chutten
:
data-review+
|
Details |
Turns out there are some telemetry probes that record memory usage in Firefox:
MEMORY_RESIDENT_FAST
MEMORY_UNIQUE
MEMORY_TOTAL
MEMORY_VSIZE
.. and other less useful-looking ones
erahm says that adding resident-peak would be easyish to add as well since we have that in about:memory and it's easy to grab.
We should check that the numbers provided by these are useful on Android (and GeckoView in particular), and that we can use these probes to compare WR on vs WR off.
|
Assignee | |
Comment 1•5 years ago
|
||
I looked at the telemetry data for Fennec for these probes and they seem sane. The data is collected for main and content processes which isn't relevant for Fennec but will be fine for GeckoView (AFAIK we're not planning on enabling a GPU process on GeckoView). I also think we should record the peak resident memory as it gives us a better view of memory usage over time as opposed to the instantaneous memory usage whenever the snapshot was taken. The implementation of that uses the getrusage linux API which should work on android, so I don't foresee any problems with adding that to the list. I'm building a patch to do that.
|
|
Assignee | |
Comment 2•5 years ago
|
||
|
|
Assignee | |
Comment 3•5 years ago
|
||
|
||
Comment 4•5 years ago
|
||
Comment on attachment 9066817 [details] Data review questionnaire DATA COLLECTION REVIEW RESPONSE: Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate? Yes. This collection is Telemetry so is documented in its definitions file [Histograms.json](https://hg.mozilla.org/mozilla-central/file/tip/toolkit/components/telemetry/Histograms.json) and the [Probe Dictionary](https://telemetry.mozilla.org/probe-dictionary/). Is there a control mechanism that allows the user to turn the data collection on and off? Yes. This collection is Telemetry so can be controlled through Firefox's Preferences. If the request is for permanent data collection, is there someone who will monitor the data over time? Yes, :kats is responsible. Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under? Category 1, Technical. Is the data collection request for default-on or default-off? Default on for all channels. Does the instrumentation include the addition of any new identifiers? No. Is the data collection covered by the existing Firefox privacy notice? Yes. Does there need to be a check-in in the future to determine whether to renew the data? No. This collection is permanent. --- Result: datareview+
Pushed by kgupta@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/af36f9152327 Record peak resident memory usage in telemetry. r=erahm
|
||
Comment 6•5 years ago
|
||
| bugherder | ||
Description
•