Closed Bug 1551675 Opened 7 months ago Closed 7 months ago

Remove Standard category pref in favor of using default values

Categories

(Firefox :: Protections UI, defect, P1)

68 Branch
defect

Tracking

()

VERIFIED FIXED
Firefox 68
Tracking Status
firefox68 --- verified
firefox69 --- verified

People

(Reporter: ewright, Assigned: ewright)

References

(Blocks 1 open bug)

Details

(Whiteboard: [anti-tracking])

Attachments

(1 file)

after Bug #1529517 landed we've had some difficulty managing the

browser.contentblocking.features.standard and browser.contentblocking.features.strict prefs.
This is especially a problem when we want to run multiple studies or do rollouts which will all run at the same time, and effect one or more of the 5 prefs governed by these two prefs.

Generally we don't do studies with the strict pref, so we can save updating that for a future time since it is not so simple.

For the standard pref we should be able to remove it. We can change the standard UI depending on whatever the default value of each of the 5 prefs. For future versions we will simply ignore this pref if it exists.
We can also match users to this category if all of their prefs are default values, and enforce default values when they click to change to it.
If we can do this by 68 that would be ideal.

Assignee: nobody → ewright
Status: NEW → ASSIGNED
Summary: Add new prefs for defining features in content blocking categories → Remove Standard category pref in favor of using default values

The standard category pref is gone.
When the default values change the standard category will change it's expectations to match.

Pushed by ewright@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b8ad543d5447
remove the Standard category pref and depend on default values to compute standard settings. r=johannh

Comment on attachment 9064891 [details]
Bug 1551675 - remove the Standard category pref and depend on default values to compute standard settings.

Beta/Release Uplift Approval Request

  • User impact if declined: This is to remove the browser.contentblocking.features.standard pref as it causes a lot of trouble with various testing and rollouts involving the content blocking tests. If this is not uplifted we are at more risk of users involved in the ETP rollout of being stuck in a state in the future where we can no longer update prefs that are set in their standard category. This greatly simplifies the rollout and will allow the rollout to only involve a single pref change if uplifted.
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: Yes
  • If yes, steps to reproduce: 1.
  • start a fresh profile
  • navigate to about:preferences#privacy, ensure you are in the standard category
  • in a new tab go to about:config
  • change the privacy.trackingprotection.cryptomining.enabled to false
  • tab back to about:preferences#privacy, you should now be in the custom category.
{
  "policies": {
    "Cookies": {
      "AcceptThirdParty": "from-visited",
      "Default": true,
      "ExpireAtSessionEnd": true
    }
  }
}
  • follow the instructions to use the custom policy then restart firefox.
  • check the standard category at about:preferences#privacy
    ER:
  • user should still be in the standard category.
  • the standard category description should have changed, such as "Cookies from unvisited sites"

To test cryptominers or fingerprinters or others which are not editable with the policies you need to change the default value of the pref and ensure the standard category description has also changed. I've been testing by changing these defaults in firefox.js.

  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): The browser.contentblocking.features.standard pref was only introduced in 68, this is removing that pref. Release users should have never seen this pref. For other users, the pref is simply being ignored, so no concerns for backward compat.
  • String changes made/needed: none
Attachment #9064891 - Flags: approval-mozilla-beta?
Flags: qe-verify+
Status: ASSIGNED → RESOLVED
Closed: 7 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 68

Comment on attachment 9064891 [details]
Bug 1551675 - remove the Standard category pref and depend on default values to compute standard settings.

This change is already in 68, no need for uplift as far as I can tell.

Attachment #9064891 - Flags: approval-mozilla-beta? → approval-mozilla-beta-

(In reply to Julien Cristau [:jcristau] from comment #5)

Comment on attachment 9064891 [details]
Bug 1551675 - remove the Standard category pref and depend on default values to compute standard settings.

This change is already in 68, no need for uplift as far as I can tell.

You are completely correct, sorry about that, I was forgetting that nightly was still 68.

Verified the issue on Nightly 69.0a1 (2019-05-20) and 68.0a1. The browser.contentblocking.features.standard pref is successfully removed.

Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.