1551700 - custom pings not sent to Debug Dashboard (in fenix)

Status: VERIFIED FIXED

(Data Platform and Tools :: Glean: SDK, defect, P3)

Description

[Richard Pappalardo [:rpapa][:rpappalardo]]

I notice when sending the custom "activation" ping in fenix “--es sendPing activation," I see locally in logcat that the activation ping is collected along w/ baseline and events, but only baseline and events arrive at the Glean Debug dashboard.

Comment 1

[Michael Droettboom [:mdroettboom]]

Attachment: GitHub Pull Request

Comment 2

[Richard Pappalardo [:rpapa][:rpappalardo]]

(In reply to Michael Droettboom [:mdroettboom] from comment #1)

Looks like this was just merged into fenix. Once it's out in nightly, I'll verify

Comment 3

[Alessio Placitelli [:Dexter]]

(In reply to Richard Pappalardo [:rpapa][:rpappalardo] from comment #2)

(In reply to Michael Droettboom [:mdroettboom] from comment #1)

Looks like this was just merged into fenix. Once it's out in nightly, I'll verify

Thanks Richard, that would be really helpful! When you get to this, would you kindly also post the full logcat output in case you have problems? It would help us very much when trying to understand this kind of weird behaviours.

Comment 4

[Richard Pappalardo [:rpapa][:rpappalardo]]

Sure :dexter np. SV discovered that Nightly fenix is no longer working today (nothing comes out on logcat).

$ adb shell -n org.mozilla.fenix/mozilla.components.service.glean.debug.GleanDebugActivity --ez logPings true --es sendPing baseline --es tagPings rpapa-test-xx

/system/bin/sh: org.mozilla.fenix/mozilla.components.service.glean.debug.GleanDebugActivity: not found

Comment 5

[Alessio Placitelli [:Dexter]]

(In reply to Richard Pappalardo [:rpapa][:rpappalardo] from comment #4)

Sure :dexter np. SV discovered that Nightly fenix is no longer working today (nothing comes out on logcat).

$ adb shell -n org.mozilla.fenix/mozilla.components.service.glean.debug.GleanDebugActivity --ez logPings true --es sendPing baseline --es tagPings rpapa-test-xx

/system/bin/sh: org.mozilla.fenix/mozilla.components.service.glean.debug.GleanDebugActivity: not found

I think they're using the wrong command, it's missing am start right after adb shell. The command should be

$ adb shell am start -n org.mozilla.fenix/mozilla.components.service.glean.debug.GleanDebugActivity --ez logPings true --es sendPing baseline --es tagPings rpapa-test-xx

Comment 6

[Richard Pappalardo [:rpapa][:rpappalardo]]

:dexter yep, my bad! I wrote the command incorrectly in the testplan. I'll fix it right now

Comment 7

[Richard Pappalardo [:rpapa][:rpappalardo]]

:dexter is it safe to assume that Bug 1550457 might be effecting the submission of custom pings as well? I know that this landed yesterday: https://github.com/mozilla-mobile/fenix/pull/2516 but I still don't seem to be able to send an activation ping from Fenix using Nightly

Comment 8

[Alessio Placitelli [:Dexter]]

(In reply to Richard Pappalardo [:rpapa][:rpappalardo] from comment #7)

:dexter is it safe to assume that Bug 1550457 might be effecting the submission of custom pings as well? I know that this landed yesterday: https://github.com/mozilla-mobile/fenix/pull/2516 but I still don't seem to be able to send an activation ping from Fenix using Nightly

It should be working now: I tested it locally and I'm able to trigger that ping. Any chance you could post the command you're using along with the related logcat output?

Comment 9

[Richard Pappalardo [:rpapa][:rpappalardo]]

(In reply to Alessio Placitelli [:Dexter] from comment #8)

It should be working now: I tested it locally and I'm able to trigger that ping. Any chance you could post the command you're using along with the related logcat output?

Sure, here's my steps...

Download target.arm.apk
https://tools.taskcluster.net/index/project.mobile.fenix.signed-nightly.nightly/latest

hmmm, maybe I miss-typed something or missed a step?? I assume using "activation" as ping type should be OK:
https://github.com/mozilla-mobile/fenix/blob/master/app/pings.yaml

ADB command:

adb shell am start -n org.mozilla.fenix/mozilla.components.service.glean.debug.GleanDebugActivity --ez logPings true --es sendPing activation --es tagPings rpapa-test-100

logcat:

2019-05-16 03:31:34.395 794-3813/? I/ActivityManager: Start proc 21475:org.mozilla.fenix/u0a203 for activity org.mozilla.fenix/mozilla.components.service.glean.debug.GleanDebugActivity
2019-05-16 03:31:34.593 21475-21493/? I/glean/Glean: Metrics enabled: true
2019-05-16 03:31:34.594 21475-21493/? I/glean/Glean: Registering pings for mozilla.components.service.glean.GleanMetrics.Pings
2019-05-16 03:31:34.666 21475-21475/? I/glean/GleanDebugActivity: Setting debug config Configuration(serverEndpoint=https://incoming.telemetry.mozilla.org, userAgent=Glean/0.52.0 (Android), connectionTimeout=10000, readTimeout=30000, maxEvents=500, logPings=true, httpClient=Lazy value not initialized yet., pingTag=rpapa-test-100, channel=null)
2019-05-16 03:31:34.666 21475-21475/? E/glean/Glean: Attempted to send unknown ping 'activation'
2019-05-16 03:31:35.822 21475-21568/? D/glean/HttpPingUploader: Glean ping to URL: /submit/org-mozilla-fenix/activation/1/cf0789cd-7597-414a-bb06-06948188dcfb
    {
      "metrics": {
        "string": {
          "activation.identifier": "Jq8m5pOWwyYoIuJkvavb9VGZguQCKgii3MSAW\/7e8ME="
        },
        "uuid": {
          "activation.activation_id": "329df234-351b-4677-844c-18e486a3602b"
        }
      },
      "ping_info": {
        "ping_type": "activation",
        "seq": 0,
        "start_time": "2019-05-16T03:31-07:00",
        "end_time": "2019-05-16T03:31-07:00"
      },
      "client_info": {
        "telemetry_sdk_build": "0.52.0",
        "first_run_date": "2019-05-16-07:00",
        "os": "Android",
        "android_sdk_version": "26",
        "os_version": "8.0.0",
        "device_manufacturer": "Huawei",
        "device_model": "Nexus 6P",
        "architecture": "arm64-v8a",
        "app_build": "11260615",
        "app_display_version": "1.0.1919"
      }
    }

Comment 10

[Alessio Placitelli [:Dexter]]

(In reply to Richard Pappalardo [:rpapa][:rpappalardo] from comment #9)

(In reply to Alessio Placitelli [:Dexter] from comment #8)

It should be working now: I tested it locally and I'm able to trigger that ping. Any chance you could post the command you're using along with the related logcat output?

Sure, here's my steps...

Download target.arm.apk
https://tools.taskcluster.net/index/project.mobile.fenix.signed-nightly.nightly/latest

I think this might not contain the fixes, because it shows:

2019-05-16 03:31:34.666 21475-21475/? E/glean/Glean: Attempted to send unknown ping 'activation'

The version on the play store works perfectly for me. I'm running your same command (copy pasted) and I get:

2019-05-17 15:23:04.199 1150-1591/? I/ActivityManager: START u0 {flg=0x10000000 cmp=org.mozilla.fenix/mozilla.components.service.glean.debug.GleanDebugActivity (has extras)} from uid 2000
2019-05-17 15:23:04.235 1150-1167/? I/ActivityManager: Start proc 23517:org.mozilla.fenix/u0a154 for activity org.mozilla.fenix/mozilla.components.service.glean.debug.GleanDebugActivity
2019-05-17 15:23:04.387 23517-23517/? I/glean/Glean: Metrics enabled: true
2019-05-17 15:23:04.388 23517-23536/? I/glean/Glean: Registering pings for org.mozilla.fenix.GleanMetrics.Pings
2019-05-17 15:23:04.389 23517-23536/? I/glean/Glean: Registering pings for mozilla.components.service.glean.GleanMetrics.Pings
2019-05-17 15:23:04.400 23517-23536/? I/glean/MetricsPingScheduler: The 'metrics' ping was already sent today
2019-05-17 15:23:04.417 23517-23517/? I/glean/GleanDebugActivity: Setting debug config Configuration(serverEndpoint=https://incoming.telemetry.mozilla.org, userAgent=Glean/0.53.0 (Android), connectionTimeout=10000, readTimeout=30000, maxEvents=500, logPings=true, httpClient=Lazy value not initialized yet., pingTag=rpapa-test-100, channel=null)
2019-05-17 15:23:04.418 23517-23549/? D/glean/PingMaker: Collecting activation
2019-05-17 15:23:04.462 23517-23565/? D/glean/PingStorageEngine: Storing ping <REDACTED> at /data/user/0/org.mozilla.fenix/glean_data/pending_pings/<REDACTED>
2019-05-17 15:23:04.480 23517-23549/? W/glean/StringsStorageEngine: search.default_engine.submission_url: Value length 69 exceeds maximum of 50
2019-05-17 15:23:04.524 23517-23597/? D/glean/PingStorageEngine: Processing persisted pings at /data/user/0/org.mozilla.fenix/glean_data/pending_pings
2019-05-17 15:23:04.527 23517-23597/? D/glean/PingStorageEngine: Processing ping: <REDACTED>
2019-05-17 15:23:04.527 23517-23597/? D/glean/HttpPingUploader: Glean ping to URL: /submit/org-mozilla-fenix/activation/1/<REDACTED>

With some relevant lines being:

2019-05-17 15:23:04.388 23517-23536/? I/glean/Glean: Registering pings for org.mozilla.fenix.GleanMetrics.Pings
2019-05-17 15:23:04.389 23517-23536/? I/glean/Glean: Registering pings for mozilla.components.service.glean.GleanMetrics.Pings
...
2019-05-17 15:23:04.418 23517-23549/? D/glean/PingMaker: Collecting activation

Comment 11

[Richard Pappalardo [:rpapa][:rpappalardo]]

(In reply to Alessio Placitelli [:Dexter] from comment #10)

Oh, that's interesting. I wonder why the PlayStore version would have it but not the latest nightly (in Taskcluster)? Wouldn't any new telemetry features land in nightly first before going out the PlayStore? Should I check w/ Fenix team?

Comment 12

[Alessio Placitelli [:Dexter]]

(In reply to Richard Pappalardo [:rpapa][:rpappalardo] from comment #11)

(In reply to Alessio Placitelli [:Dexter] from comment #10)

Oh, that's interesting. I wonder why the PlayStore version would have it but not the latest nightly (in Taskcluster)? Wouldn't any new telemetry features land in nightly first before going out the PlayStore? Should I check w/ Fenix team?

We found, thanks to Bogdan, that there was another issue: pings with no client_id were not displayed on the dashboard. We are fixing that problem, will close this bug once that's settled.

Comment 13

[Alessio Placitelli [:Dexter]]

The related PR was fixed, pings are now showing up. Closing this.

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/14c5b3f10042
[fenix] 1551700: Enable custom pings from debug dashboard (https://github.com/mozilla-mobile/fenix/pull/2516)