Closed Bug 1551711 Opened 6 years ago Closed 5 years ago

Add alt text property to snippet schema

Categories

(Firefox :: Messaging System, enhancement, P1)

enhancement

Tracking

()

VERIFIED FIXED
Firefox 69
Iteration:
69.3 - Jun 10 - 23
Tracking Status
firefox68 --- wontfix
firefox69 --- verified

People

(Reporter: emcminn, Assigned: emcminn)

References

(Blocks 1 open bug)

Details

(Keywords: github-merged)

Attachments

(1 file)

Add optional alt text to snippet icons for accessibility purposes. See if this is reasonable for the Snippets team.

Iteration: --- → 69.1 - May 13 - 26
Priority: -- → P2
No longer blocks: 1511152
Priority: P2 → --
Blocks: 1554739
Iteration: 69.1 - May 13 - 26 → 69.2 - May 27 - Jun 9
Priority: -- → P2
Iteration: 69.2 - May 27 - Jun 9 → 69.3 - Jun 10 - 23
Assignee: nobody → emcminn
Priority: P2 → P1
Blocks: 1559536
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED

Hi Emily, are these server-side changes or we can see them in the browser?

Flags: needinfo?(emcminn)

(In reply to Marius Coman [:mcoman], Experiments QA from comment #3)

Hi Emily, are these server-side changes or we can see them in the browser?

It's a front-end change that sets us up to accept the prop from the server once it's available - right now the front end will be using the fallback string because the data isn't present. (The fallback is just an empty string, to flag images/icons as decorative for screen readers.) It's also an optional prop, so there's no need to go back and fill it in; it's just there to be used going forward :)

Flags: needinfo?(emcminn)

I have verified this issue with the latest Firefox Nightly (69.0a1 Build ID - 20190619214046) installed, on Windows 10 x64, Arch Linux and Mac 10.14.5. Now, "Alt" text is set to an empty string as specified in comment 4.

Status: RESOLVED → VERIFIED
Component: Activity Streams: Newtab → Messaging System
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: