1551716 - Cleanup a bit IntersectionObserver.

Status: RESOLVED FIXED

(Core :: Layout, task, P3)

Description

[Emilio Cobos Álvarez (:emilio)]

This would've made my life so much easier in bug 1505471.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1551716 - Simplify the cross-origin check in IntersectionObserver. r=mstange

Should've no behavior change given the spec issue, but it should read nicer.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1551716 - Use ranged-for loop in DOMIntersectionObserver. r=mstange

There's nothing here that should be mutating us (and if there was we'd be hosed
already given the amount of weak pointers we keep around), so this is nicer.

Depends on D31148

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1551716 - Deindent some IntersectionObserver code. r=mstange

Just trying to make it slightly nicer. Probably should get a function to get the
root target document frame.

Will file a bug for fission since I suspect fission is going to do something
about IntersectionObserver.

Depends on D31149

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1551716 - Factor out some intersection observer code, and add spec quotes.

This would've made my life a lot easier. There's a couple things that don't
match the spec that I've left as comments.

Depends on D31150

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/99f6369994c5
Simplify the cross-origin check in IntersectionObserver. r=mstange

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/24b0ba66a251
Use ranged-for loop in DOMIntersectionObserver. r=mstange
https://hg.mozilla.org/integration/autoland/rev/953bbdd4483a
Deindent some IntersectionObserver code. r=mstange

Comment 7

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/99f6369994c5
https://hg.mozilla.org/mozilla-central/rev/24b0ba66a251
https://hg.mozilla.org/mozilla-central/rev/953bbdd4483a

Comment 8

[Emilio Cobos Álvarez (:emilio)]

Markus, review ping here?

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6ce9dcc31c42
Factor out some intersection observer code, and add spec quotes. r=mstange

Comment 10

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/6ce9dcc31c42