Closed Bug 1551716 Opened 1 year ago Closed 10 months ago

Cleanup a bit IntersectionObserver.

Categories

(Core :: Layout, task, P3)

task

Tracking

()

RESOLVED FIXED

People

(Reporter: emilio, Assigned: emilio, NeedInfo)

References

Details

Attachments

(4 files)

This would've made my life so much easier in bug 1505471.

Should've no behavior change given the spec issue, but it should read nicer.

There's nothing here that should be mutating us (and if there was we'd be hosed
already given the amount of weak pointers we keep around), so this is nicer.

Depends on D31148

Just trying to make it slightly nicer. Probably should get a function to get the
root target document frame.

Will file a bug for fission since I suspect fission is going to do something
about IntersectionObserver.

Depends on D31149

This would've made my life a lot easier. There's a couple things that don't
match the spec that I've left as comments.

Depends on D31150

Keywords: leave-open
Type: defect → task
Priority: -- → P3
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/99f6369994c5
Simplify the cross-origin check in IntersectionObserver. r=mstange
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/24b0ba66a251
Use ranged-for loop in DOMIntersectionObserver. r=mstange
https://hg.mozilla.org/integration/autoland/rev/953bbdd4483a
Deindent some IntersectionObserver code. r=mstange

Markus, review ping here?

Flags: needinfo?(mstange)
Blocks: 1581876
Attachment #9064906 - Attachment description: Bug 1551716 - Factor out some intersection observer code, and add spec quotes. r=mstange → Bug 1551716 - Factor out some intersection observer code, and add spec quotes.
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6ce9dcc31c42
Factor out some intersection observer code, and add spec quotes. r=mstange
Status: NEW → RESOLVED
Closed: 10 months ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.