1551775 - Snap with the keyboard doesn't work correctly on Firefox Nightly windows

Status: RESOLVED INVALID

(Core :: Window Management, defect, P3)

Description

[alex_mayorga]

Attachment: Screen Recording 2019-05-14 at 09.51.04.60 PM.mp4

¡Hola!

Using the Windows snap keyboard shortcuts as detailed at https://support.microsoft.com/en-us/help/4027324/windows-10-snap-your-windows doesn't work correctly or reliably on Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 Firefox/68.0 ID:20190514214217

Please see the attached screen recording.

Steps

• Maximize a Firefox Nightly window
• Press Windows Logo Key + Left Arrow to snap that window to the left side of the screen
• Repeat the previous step multiple times

Actual result

After the 5th or 6th repeat the Firefox Nightly window does not snap to the sides anymore and there are gaps on the snapping to the edges, the tab bar at the top gets clipped by the screen border on the top.

Expected result

The Firefox Nightly window does continues to snap to the sides regardless of the number of repeats, there are no visible gaps on the snapping to the edges and the tab bar at the top doesn't get clipped by the screen border on the top.

¡Gracias!
Alex

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The priority flag is not set for this bug.
:enndeakin, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 2

[Neil Deakin]

I don't see this issue on 69.

Comment 3

[Cristian Fogel [:cfogel]]

Was unable to reproduce either.
Attempted with:

• 69.0a1 (2019-06-06) on Windows 10, macOS 10.13, Ubuntu 18.04
• 68.0a1(2019-05-14) on Windows 10.

@Alex, does it still reproduce on the current nightly builds?

Comment 4

[alex_mayorga]

Attachment: Screen Recording 2019-06-13 at 12.49.11.84 AM.mp4

¡Hola Cristian!

Yup! Still a thing on Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:69.0) Gecko/20100101 Firefox/69.0 ID:20190612172942 with Windows 10 Insider Preview Build 18908.rs_prerelease.190524-1658

Please note on the attached video how the tab bar gets clipped a bit at the top when one uses Win + <- or -> to maximize Nightly to half the screen. Very noticeable given that the blue highlight of the current tab goes out of sight.

At 1st I thought this to be related to poor multi monitor support on Windows 10 Insider Preview Build 18908.rs_prerelease.190524-1658 but on this video there were no external monitors connected so not a factor anymore.

Steps:

• Have a maximized Nightly window
• Press Win + <-

Actual results:
The Nightly window shrinks to 50% horizontally but the top of the tab bar is clipped a few pixels at the top, the blue highlight of the current tab goes out of sight.

Expected results:
The Nightly window shrinks to 50% horizontally but the top of the tab bar is NOT clipped a few pixels at the top, the blue highlight of the current tab is still visible.

Hope this helps clarify.

¡Gracias!
Alex

Comment 5

[alex_mayorga]

¡Hola!

On closer inspection, the bottom border of the window also goes missing when this happens so I believe that the height of the window is miss calculated by some pixels and made taller than the actual screen height.

¡Gracias!
Alex

Comment 6

[Cristian Fogel [:cfogel]]

Hello again Alex and sorry for the delayed response.

In another attempt to reproduce with the current Nightly build, tried on Windows 10 (1803 and 1809) but to no success. The snapp-ing semes to work as expected.
It might be that it's only for your version.
Any chance you could run a regression check for this issue with mozregression?
Would help out and speed up the process.

Thanks for your patience with this!

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug is a regression, but please revert this change in case of error.

Comment 8

[Trevor Rowbotham [:rowbot]]

I can reproduce this, but I think this is a Windows problem rather than a Firefox problem. The same thing happens with Edge when it transitions from being maximized to a snapped state.

Comment 9

[Marcia Knous [:marcia]]

Discussed during platform triage. Removing the regression keyword/r-w wanted keyword based on Comment 8.

Comment 10

[Trevor Rowbotham [:rowbot]]

I've filed a feedback issue with Microsoft. https://aka.ms/AA5su3c (you will need to open the link in Edge to get it to redirect to the Windows Feedback Hub)

Comment 11

[alex_mayorga]

¡Hola Trevor!

You're right!

This happens even on notepad.exe in build 18975.

The window tiling behaves rather erratically IMHO.

¡Gracias!
Alex