Stop using [array] in places IDLs

RESOLVED FIXED in Firefox 68

Status

()

task
RESOLVED FIXED
Last month
Last month

People

(Reporter: bzbarsky, Assigned: bzbarsky)

Tracking

(Blocks 2 bugs)

unspecified
mozilla68
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox68 fixed)

Details

Attachments

(6 attachments, 1 obsolete attachment)

No description provided.
Blocks: 1551782

The old code used variants with SetAsAUTF8String, which would get converted to
a string when going into JS. We can just use Array<AUTF8String> directly
instead. C++ callers would need to change, but there aren't any.

That said, there are no non-test callers either, so maybe we could just remove
this API?

I audited the various callsites that pass in nsIFaviconDataCallback to
nsIFaviconService methods. I think I got all the ones that needed changing...

Blocks: 1552149

I'm going to move part 7 to a different bug, and see whether I can avoid that data copy it adds.

Attachment #9065054 - Attachment is obsolete: true

Comment 9

Last month
Pushed by bzbarsky@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/722c158c5386
part 1.  Stop using [array] for get/setTransitions in nsINavHistoryService.  r=mak
https://hg.mozilla.org/integration/autoland/rev/f5db7f234584
part 2.  Stop using [array] for get/setParents in nsINavHistoryService.  r=mak
https://hg.mozilla.org/integration/autoland/rev/4c91b3e1fede
part 3.  Stop using [array] for nsINavHistoryService.getObservers and nsINavBookmarksService.getObservers.  r=mak
https://hg.mozilla.org/integration/autoland/rev/87a537f8e5a8
part 4.  Stop using [array] for getItemAnnotationNames.  r=mak
https://hg.mozilla.org/integration/autoland/rev/5db31f792bf4
part 5.  Stop using [array] for getTagsForURI.  r=mak
https://hg.mozilla.org/integration/autoland/rev/fb8cc6cad30a
part 6.  Stop using [array] for replaceFaviconData.  r=mak
You need to log in before you can comment on or make changes to this bug.