1551779 - Stop using [array] in places IDLs

Status: RESOLVED FIXED

(Toolkit :: Places, task)

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Bug 1551779 part 1. Stop using [array] for get/setTransitions in nsINavHistoryService. r=mak

Comment 2

[Boris Zbarsky [:bzbarsky]]

Attachment: Bug 1551779 part 2. Stop using [array] for get/setParents in nsINavHistoryService. r=mak

Comment 3

[Boris Zbarsky [:bzbarsky]]

Attachment: Bug 1551779 part 3. Stop using [array] for nsINavHistoryService.getObservers and nsINavBookmarksService.getObservers. r=mak

Comment 4

[Boris Zbarsky [:bzbarsky]]

Attachment: Bug 1551779 part 4. Stop using [array] for getItemAnnotationNames. r=mak

The old code used variants with SetAsAUTF8String, which would get converted to
a string when going into JS. We can just use Array<AUTF8String> directly
instead. C++ callers would need to change, but there aren't any.

That said, there are no non-test callers either, so maybe we could just remove
this API?

Comment 5

[Boris Zbarsky [:bzbarsky]]

Attachment: Bug 1551779 part 5. Stop using [array] for getTagsForURI. r=mak

Comment 6

[Boris Zbarsky [:bzbarsky]]

Attachment: Bug 1551779 part 6. Stop using [array] for replaceFaviconData. r=mak

Comment 7

[Boris Zbarsky [:bzbarsky]]

Attachment: Bug 1551779 part 7. Stop using [array] in nsIFaviconDataCallback. r=mak

I audited the various callsites that pass in nsIFaviconDataCallback to
nsIFaviconService methods. I think I got all the ones that needed changing...

Comment 8

[Boris Zbarsky [:bzbarsky]]

I'm going to move part 7 to a different bug, and see whether I can avoid that data copy it adds.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/722c158c5386
part 1.  Stop using [array] for get/setTransitions in nsINavHistoryService.  r=mak
https://hg.mozilla.org/integration/autoland/rev/f5db7f234584
part 2.  Stop using [array] for get/setParents in nsINavHistoryService.  r=mak
https://hg.mozilla.org/integration/autoland/rev/4c91b3e1fede
part 3.  Stop using [array] for nsINavHistoryService.getObservers and nsINavBookmarksService.getObservers.  r=mak
https://hg.mozilla.org/integration/autoland/rev/87a537f8e5a8
part 4.  Stop using [array] for getItemAnnotationNames.  r=mak
https://hg.mozilla.org/integration/autoland/rev/5db31f792bf4
part 5.  Stop using [array] for getTagsForURI.  r=mak
https://hg.mozilla.org/integration/autoland/rev/fb8cc6cad30a
part 6.  Stop using [array] for replaceFaviconData.  r=mak

Comment 10

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/722c158c5386
https://hg.mozilla.org/mozilla-central/rev/f5db7f234584
https://hg.mozilla.org/mozilla-central/rev/4c91b3e1fede
https://hg.mozilla.org/mozilla-central/rev/87a537f8e5a8
https://hg.mozilla.org/mozilla-central/rev/5db31f792bf4
https://hg.mozilla.org/mozilla-central/rev/fb8cc6cad30a