1551842 - [Clang-Tidy] Add new checkers from clang-tidy 8.0

Status: RESOLVED FIXED

(Developer Infrastructure :: Source Code Analysis, enhancement)

Description

[Andi [:andi]]

Since we've moved from clang 7.0.1 to clang 8.0.0 this upgrade came with a suit of new checkers that have been implemented or updated in the later version. From these we've decided to activate the following:

• bugprone-too-small-loop-variable
• cppcoreguidelines-narrowing-conversions
• modernize-deprecated-ios-base-aliases
• readability-const-return-type
• readability-isolate-declaration
• readability-magic-numbers

The reasoning why these checkers have been added are based on a cumulative aspects like:

• a low yield of false positives
• coherence with out coding style
• coherence with our current practices

Regression tests:

• Win64
• Linux64

Comment 1

[Andi [:andi]]

Attachment: Bug 1551842 - Add new clang-tidy checkers from clang 8.0.0. r=sylvestre

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a234872a4356
Add new clang-tidy checkers from clang 8.0.0. r=sylvestre,froydnj

Comment 3

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/a234872a4356