1551878 - [BinAST] Implement reading string dictionary

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P3)

Description

[Tooru Fujisawa [:arai]]

Once bug 1551473 gets fixed, we can now read brotli-compressed stream.

the first section is string dictionary, that I'm going to change to this https://github.com/binast/binjs-fbssdc/pull/11 format.

the first step would just implement this part for encoded JS file (not dictionary file)

Comment 1

[Tooru Fujisawa [:arai]]

I'll go without https://github.com/binast/binjs-fbssdc/pull/11 change first, given the change regresses compression ratio.
Also, I'll go without supporting 0x01-escape first, given it has issue around 0x00

Comment 2

[Tooru Fujisawa [:arai]]

filed https://github.com/binast/binjs-fbssdc/issues/12 for 0x01-escape issue.

Comment 3

[Tooru Fujisawa [:arai]]

Attachment: Bug 1551878 - Implement reading string dictionary, without 0x01-escape handling. r?Yoric

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7d502b065b54
Implement reading string dictionary, without 0x01-escape handling. r=Yoric

Comment 5

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/7d502b065b54