Closed Bug 1551882 Opened 1 year ago Closed 1 year ago

Refactor the print preview listener code to make its purpose clear

Categories

(Core :: Printing: Setup, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla68
Tracking Status
firefox68 --- fixed

People

(Reporter: jwatt, Assigned: jwatt)

Details

Attachments

(1 file)

No description provided.
Pushed by jwatt@jwatt.org:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b224c05dc123
Refactor the print preview listener code to make its purpose clear. r=bobowen

I changed this prior to landing to require explicit removal of the listeners since otherwise we leak. See the comment for the added function StopSuppressing(). As a result I also removed the "Auto" from the name of the new class. needinfo to make sure you're aware of those changes.

Flags: needinfo?(bobowencode)
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68

(In reply to Jonathan Watt [:jwatt] from comment #3)

I changed this prior to landing to require explicit removal of the listeners since otherwise we leak. See the comment for the added function StopSuppressing(). As a result I also removed the "Auto" from the name of the new class. needinfo to make sure you're aware of those changes.

OK thanks, I thought you were handling the release and RemoveListeners through the destructor.

Flags: needinfo?(bobowencode)

(In reply to Bob Owen (:bobowen) from comment #5)

OK thanks, I thought you were handling the release and RemoveListeners through the destructor.

As noted in comment 3, the comment documenting StopSuppressing() explains why I had to change that. :) I believe from our conversation on IRC that everything makes sense now.

You need to log in before you can comment on or make changes to this bug.