1551882 - Refactor the print preview listener code to make its purpose clear

Status: RESOLVED FIXED

(Core :: Printing: Setup, defect, P3)

Comment 1

[Jonathan Watt [:jwatt]]

Attachment: Bug 1551882. Refactor the print preview listener code to make its purpose clear. r=bobowen

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b224c05dc123
Refactor the print preview listener code to make its purpose clear. r=bobowen

Comment 3

[Jonathan Watt [:jwatt]]

I changed this prior to landing to require explicit removal of the listeners since otherwise we leak. See the comment for the added function StopSuppressing(). As a result I also removed the "Auto" from the name of the new class. needinfo to make sure you're aware of those changes.

Comment 4

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/b224c05dc123

Comment 5

[Bob Owen (:bobowen) PTO until 13th Aug]

(In reply to Jonathan Watt [:jwatt] from comment #3)

I changed this prior to landing to require explicit removal of the listeners since otherwise we leak. See the comment for the added function StopSuppressing(). As a result I also removed the "Auto" from the name of the new class. needinfo to make sure you're aware of those changes.

OK thanks, I thought you were handling the release and RemoveListeners through the destructor.

Comment 6

[Jonathan Watt [:jwatt]]

(In reply to Bob Owen (:bobowen) from comment #5)

OK thanks, I thought you were handling the release and RemoveListeners through the destructor.

As noted in comment 3, the comment documenting StopSuppressing() explains why I had to change that. :) I believe from our conversation on IRC that everything makes sense now.