Refactor the print preview listener code to make its purpose clear

RESOLVED FIXED in Firefox 68

Status

()

defect
P3
normal
RESOLVED FIXED
Last month
Last month

People

(Reporter: jwatt, Assigned: jwatt)

Tracking

unspecified
mozilla68
Points:
---

Firefox Tracking Flags

(firefox68 fixed)

Details

Attachments

(1 attachment)

Assignee

Description

Last month
No description provided.

Comment 2

Last month
Pushed by jwatt@jwatt.org:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b224c05dc123
Refactor the print preview listener code to make its purpose clear. r=bobowen
Assignee

Comment 3

Last month

I changed this prior to landing to require explicit removal of the listeners since otherwise we leak. See the comment for the added function StopSuppressing(). As a result I also removed the "Auto" from the name of the new class. needinfo to make sure you're aware of those changes.

Flags: needinfo?(bobowencode)

Comment 4

Last month
bugherder
Status: NEW → RESOLVED
Closed: Last month
Resolution: --- → FIXED
Target Milestone: --- → mozilla68

(In reply to Jonathan Watt [:jwatt] from comment #3)

I changed this prior to landing to require explicit removal of the listeners since otherwise we leak. See the comment for the added function StopSuppressing(). As a result I also removed the "Auto" from the name of the new class. needinfo to make sure you're aware of those changes.

OK thanks, I thought you were handling the release and RemoveListeners through the destructor.

Flags: needinfo?(bobowencode)
Assignee

Comment 6

Last month

(In reply to Bob Owen (:bobowen) from comment #5)

OK thanks, I thought you were handling the release and RemoveListeners through the destructor.

As noted in comment 3, the comment documenting StopSuppressing() explains why I had to change that. :) I believe from our conversation on IRC that everything makes sense now.

You need to log in before you can comment on or make changes to this bug.