Closed Bug 1551959 Opened 6 years ago Closed 6 years ago

support for osx 10.10 and 10.14

Categories

(Tree Management :: Treeherder, task, P2)

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: jmaher, Assigned: camd)

References

Details

Attachments

(2 files)

previously we had data from taskcluster producing macosx64 == "osx 10.10", now we have macosx1010-64 and macosx1014-64, these should be supported in treeherder.

I believe changes need to be in this file:
https://github.com/mozilla/treeherder/blob/master/ui/helpers/constants.js#L26

:camd, is this something you could pick up this week- it should be fairly easy, but if it is more complicated we should prioritize it based on other work.

Flags: needinfo?(cdawson)

Sure, you bet. PR attached.

Flags: needinfo?(cdawson)
Assignee: nobody → cdawson
Status: NEW → ASSIGNED

Setting to P2 as I expect this will get merged before Whistler.

Type: defect → task
Priority: -- → P2

Looks like this is mostly working now with the merge of PR4978. However, there's still some jobs which aren't getting prettified:
https://treeherder.mozilla.org/#/jobs?repo=mozilla-central&searchStr=mac&revision=fee989d27558bdbf83351633f09bd7f80d16f2d4

Looks like we need to cover the macosx1010-64 and macosx1014-64 cases as well.

Flags: needinfo?(cdawson)

I'll write up a new PR for this Monday.

Flags: needinfo?(cdawson)
Attachment #9071305 - Flags: review?(ryanvm)
Attachment #9071305 - Flags: review?(ryanvm) → review+
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: