1552126 - Eliminate UpdatePolicy::Skip

Status: RESOLVED FIXED

(Core :: Preferences: Backend, enhancement, P3)

Description

[Jean-Yves Avenard [:jya]]

Mentioned in bug 1550422, P13.

A Preference has a concept of locking.

When we set a Preference of type Skip, we should lock the underlying preference.

Maybe consider renaming Skip policy into Lock maybe?

Comment 1

[Nicholas Nethercote [inactive]]

On second thought: UpdatePolicy::Skip is used by only two static prefs out of 850+, only in some configurations, and it can be emulated at the use sites. Let's just get rid of it; it's not worth having the complexity in libpref for such a small number of uses.

Comment 2

[Nicholas Nethercote [inactive]]

Attachment: Bug 1552126 - Convert gfx.blocklist.all to a non-Skip pref. r=mattwoodrow

Comment 3

[Nicholas Nethercote [inactive]]

Attachment: Bug 1552126 - Convert layers.componentalpha.enabled to a non-Skip pref. r=mattwoodrow

Depends on D37371

Comment 4

[Nicholas Nethercote [inactive]]

Attachment: Bug 1552126: Remove `UpdatePolicy::Skip`. r=jya

Depends on D37372

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9e949b549d68
Convert gfx.blocklist.all to a non-Skip pref. r=mattwoodrow
https://hg.mozilla.org/integration/autoland/rev/86ee4958f7f9
Convert layers.componentalpha.enabled to a non-Skip pref. r=mattwoodrow
https://hg.mozilla.org/integration/autoland/rev/f452d5bfffd0
Remove `UpdatePolicy::Skip`. r=jya

Comment 6

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/9e949b549d68
https://hg.mozilla.org/mozilla-central/rev/86ee4958f7f9
https://hg.mozilla.org/mozilla-central/rev/f452d5bfffd0