Closed
Bug 1552126
Opened 5 years ago
Closed 5 years ago
Eliminate UpdatePolicy::Skip
Categories
(Core :: Preferences: Backend, enhancement, P3)
Core
Preferences: Backend
Tracking
()
RESOLVED
FIXED
mozilla70
| Tracking | Status | |
|---|---|---|
| firefox70 | --- | fixed |
People
(Reporter: jya, Assigned: n.nethercote)
References
Details
Attachments
(3 files)
Mentioned in bug 1550422, P13.
A Preference has a concept of locking.
When we set a Preference of type Skip, we should lock the underlying preference.
Maybe consider renaming Skip policy into Lock maybe?
|
Assignee | |
Updated•5 years ago
|
Priority: -- → P3
|
|
Assignee | |
Comment 1•5 years ago
|
||
On second thought: UpdatePolicy::Skip is used by only two static prefs out of 850+, only in some configurations, and it can be emulated at the use sites. Let's just get rid of it; it's not worth having the complexity in libpref for such a small number of uses.
Summary: When a StaticPrefs of type Skip is used; lock the underlying preference. → Eliminate UpdatePolicy::Skip
|
|
Assignee | |
Comment 2•5 years ago
|
||
|
|
Assignee | |
Comment 3•5 years ago
|
||
Depends on D37371
|
|
Assignee | |
Comment 4•5 years ago
|
||
Depends on D37372
Pushed by nnethercote@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/9e949b549d68 Convert gfx.blocklist.all to a non-Skip pref. r=mattwoodrow https://hg.mozilla.org/integration/autoland/rev/86ee4958f7f9 Convert layers.componentalpha.enabled to a non-Skip pref. r=mattwoodrow https://hg.mozilla.org/integration/autoland/rev/f452d5bfffd0 Remove `UpdatePolicy::Skip`. r=jya
|
||
Comment 6•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/9e949b549d68
https://hg.mozilla.org/mozilla-central/rev/86ee4958f7f9
https://hg.mozilla.org/mozilla-central/rev/f452d5bfffd0
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox70:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla70
|
||
Updated•5 years ago
|
Assignee: nobody → n.nethercote
You need to log in
before you can comment on or make changes to this bug.
Description
•