Closed Bug 1552193 Opened 1 year ago Closed 1 year ago

Search Telemetry reporting should match the codes that were used before the conversion to WebExtensions

Categories

(Firefox :: Search, defect, P1)

defect
Points:
2

Tracking

()

RESOLVED FIXED
Firefox 69
Iteration:
69.1 - May 13 - 26
Tracking Status
firefox-esr60 --- unaffected
firefox66 --- unaffected
firefox67 --- unaffected
firefox68 + fixed
firefox69 --- fixed

People

(Reporter: standard8, Assigned: daleharvey)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file)

We've identified that our telemetry reporting for search engines has changed the reports since the conversion to WebExtensions.

The values appear that they used to be based on the values in list.json, however they are now just the extension short names. In some cases this looses us slightly more detailed information as to exactly which versions of the engines are in use.

[Tracking Requested - why for this release]: This affects are monitoring and reporting.

Assignee: nobody → dharvey
Pushed by dharvey@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/37b6e7e47cce
Restore engine shortName to pre webextensions value. r=Standard8
Backout by shindli@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/181ef326f7a8
Backed out changeset 37b6e7e47cce for causing Mn failures in browser\components\search\test\marionette\test_engines_on_restart.py CLOSED TREE
Pushed by dharvey@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b404f7a62f2f
Restore engine shortName to pre webextensions value. r=Standard8
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 69
Flags: needinfo?(dharvey)

Comment on attachment 9066208 [details]
Bug 1552193 - Restore engine shortName to pre webextensions value. r?Standard8

Beta/Release Uplift Approval Request

  • User impact if declined: Not user facing, little user impact
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Changes the name reported via telemetry so existing querying can be maintained, the functional impact is minimal and covered by tests
  • String changes made/needed:
Attachment #9066208 - Flags: approval-mozilla-beta?

Comment on attachment 9066208 [details]
Bug 1552193 - Restore engine shortName to pre webextensions value. r?Standard8

search telemetry fix, approved for 68.0b5

Attachment #9066208 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Iteration: --- → 69.1 - May 13 - 26
Points: --- → 2
You need to log in before you can comment on or make changes to this bug.