1552226 - spidermonkey configured with --disable-ion fails to compile on arm with: src/jit/arm/Architecture-arm.h:37:22: error: redefinition of 'const int32_t js::jit::NUNBOX32_TYPE_OFFSET' (and many more)

Status: RESOLVED WONTFIX

(Core :: JavaScript Engine: JIT, defect, P5)

Description

[tt_1]

Attachment: spidermonkey-build-arm.gz

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Firefox/60.0

Steps to reproduce:

--enable-ion enables jit compilation, which is reasonable more memory hungry. So I decided to turn that off via --disable-ion, to save a few percent and have less swapping.

Actual results:

the compile fails with all sorts of redefinitions and conflicts:

/var/tmp/portage/dev-lang/spidermonkey-60.5.2_p0-r2/work/mozjs-60.5.2/js/src/jit/arm/Architecture-arm.h:37:22: error: redefinition of 'const int32_t js::jit::NUNBOX32_TYPE_OFFSET'
/var/tmp/portage/dev-lang/spidermonkey-60.5.2_p0-r2/work/mozjs-60.5.2/js/src/jit/arm/Architecture-arm.h:38:22: error: redefinition of 'const int32_t js::jit::NUNBOX32_PAYLOAD_OFFSET'
/var/tmp/portage/dev-lang/spidermonkey-60.5.2_p0-r2/work/mozjs-60.5.2/js/src/jit/arm/Architecture-arm.h:40:23: error: redefinition of 'const uint32_t js::jit::ShadowStackSpace'
/var/tmp/portage/dev-lang/spidermonkey-60.5.2_p0-r2/work/mozjs-60.5.2/js/src/jit/arm/Architecture-arm.h:43:23: error: redefinition of 'const uint32_t js::jit::JumpImmediateRange'
/var/tmp/portage/dev-lang/spidermonkey-60.5.2_p0-r2/work/mozjs-60.5.2/js/src/jit/arm/Architecture-arm.h:56:7: error: redefinition of 'class js::jit::Registers'
/var/tmp/portage/dev-lang/spidermonkey-60.5.2_p0-r2/work/mozjs-60.5.2/js/src/jit/arm/Architecture-arm.h:166:18: error: conflicting declaration 'typedef uint16_t js::jit::PackedRegisterMask'
/var/tmp/portage/dev-lang/spidermonkey-60.5.2_p0-r2/work/mozjs-60.5.2/js/src/jit/arm/Architecture-arm.h:167:18: error: conflicting declaration 'typedef uint16_t js::jit::PackedRegisterMask'
/var/tmp/portage/dev-lang/spidermonkey-60.5.2_p0-r2/work/mozjs-60.5.2/js/src/jit/arm/Architecture-arm.h:169:7: error: redefinition of 'class js::jit::FloatRegisters'
/var/tmp/portage/dev-lang/spidermonkey-60.5.2_p0-r2/work/mozjs-60.5.2/js/src/jit/arm/Architecture-arm.h:444:44: error: 'GetDoubleName' is not a member of 'js::jit::FloatRegisters'
/var/tmp/portage/dev-lang/spidermonkey-60.5.2_p0-r2/work/mozjs-60.5.2/js/src/jit/arm/Architecture-arm.h:445:28: error: 'GetSingleName' is not a member of 'js::jit::FloatRegisters'
/var/tmp/portage/dev-lang/spidermonkey-60.5.2_p0-r2/work/mozjs-60.5.2/js/src/jit/arm/Architecture-arm.h:549:35: error: static assertion failed: SetType must be 64 bits
/var/tmp/portage/dev-lang/spidermonkey-60.5.2_p0-r2/work/mozjs-60.5.2/js/src/jit/arm/Architecture-arm.h:622:33: error: 'TotalSingle' is not a member of 'js::jit::FloatRegisters'
/var/tmp/portage/dev-lang/spidermonkey-60.5.2_p0-r2/work/mozjs-60.5.2/js/src/jit/arm/Architecture-arm.h:631:32: error: 'TotalSingle' is not a member of 'js::jit::FloatRegisters'
/var/tmp/portage/dev-lang/spidermonkey-60.5.2_p0-r2/work/mozjs-60.5.2/js/src/jit/arm/Architecture-arm.h:634:33: error: 'TotalDouble' is not a member of 'js::jit::FloatRegisters'
/var/tmp/portage/dev-lang/spidermonkey-60.5.2_p0-r2/work/mozjs-60.5.2/js/src/jit/arm/Architecture-arm.h:643:21: error: conflicting declaration 'typedef class js::jit::VFPRegister js::jit::FloatRegister'
/var/tmp/portage/dev-lang/spidermonkey-60.5.2_p0-r2/work/mozjs-60.5.2/js/src/jit/arm/Architecture-arm.h:696:13: error: redefinition of 'bool js::jit::hasUnaliasedDouble()'
/var/tmp/portage/dev-lang/spidermonkey-60.5.2_p0-r2/work/mozjs-60.5.2/js/src/jit/arm/Architecture-arm.h:700:13: error: redefinition of 'bool js::jit::hasMultiAlias()'

Expected results:

the compile should have passed fine, as it does for amd64

full and compressed build.log is attached

Comment 1

[Nicolas B. Pierron [:nbp]]

This is not one of our tested configuration, we'll accept a patch for this.
If you need help you can ask questions on IRC, on the #jsapi channel

Comment 2

[tt_1]

yeah, that header file in question wasn't touched for many years. Since I don't have any skills in writing code and the irc beomg rather difficult to approach, I'm going to close this as wontfix.