1552256 - OTR, buddy right click, "add OTR fingerprint" for online contacts is broken

Status: RESOLVED FIXED

(Chat Core :: Security: OTR, defect)

Description

[Kai Engert [:KaiE:]]

In the original code snapshot (pre-review), the right-click menu entry "add contact's OTR fingerprint" was shown for offline contact's, only.

Today during testing I saw that the menu item is present for online contacts, too.

However, it's broken. When selecting it, I get error "TypeError: contact.preferredBuddy is undefined"

For now, as an immediate bugfix (after bug 1518172 landed), I suggest to NOT show the menu for online contacts.

Comment 1

[Alessandro Castellani [:aleca]]

I'm taking care of this, which is related to Bug 1549935

Upon right clicking on a contact's name I'm getting this console warning.
console.warn: "[fluent] Missing translations in en-US: buddycontextmenu.label."

Kai, I know you converted the translatable strings to Fluent, is this something you can take care of or point me to the right direction?

Comment 2

[Alessandro Castellani [:aleca]]

After further investigation, the TypeError: contact.preferredBuddy is undefined warning appears only if the conversation with that contact is open, independently if the contact is online or offline.

Comment 3

[Alessandro Castellani [:aleca]]

Attachment: otr-buddy-right-click.patch

Comment 4

[Magnus Melin [:mkmelin]]

Comment on attachment 9067849 [details] [diff] [review]
otr-buddy-right-click.patch

Review of attachment 9067849 [details] [diff] [review]:
-----------------------------------------------------------------

Looks a bit weird with the declarations. Can we change these (both) to be

if (contact.buddy) {
  return {

  }
}
return {

}

Also add a comment about online/offline?

Comment 5

[Alessandro Castellani [:aleca]]

Attachment: otr-buddy-right-click.patch

Comment 6

[Kai Engert [:KaiE:]]

(In reply to Alessandro Castellani (:aleca) from comment #1)

Upon right clicking on a contact's name I'm getting this console warning.
console.warn: "[fluent] Missing translations in en-US: buddycontextmenu.label."

buddycontextmenu.label must be changed in OTRUI.jsm to buddycontextmenu-label

Comment 7

[Alessandro Castellani [:aleca]]

Attachment: otr-buddy-right-click.patch

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/2e120efeddbf
Fix "Add Contact's OTR Fingerprint" for contact with open conversation. r=mkmelin

Comment 9

[Jorg K (CEST = GMT+2)]

I was agonising a bit over the commit message here. Even as a non-native English speaker "opened conversation" sounds wrong. The adjective is "open". "Opened" is used in "Juliet opened her eyes and saw, oh dear, ..." - https://dictionary.cambridge.org/grammar/british-grammar/open-or-opened. Or maybe that's another "Americanism".

Comment 10

[Jorg K (CEST = GMT+2)]

TB 68 beta:
https://hg.mozilla.org/releases/comm-beta/rev/3af65f0ade9ccaf6d18a3c9c973d0bd6b05d5f33