1552275 - Copy link address from inspector doesn't work

Status: VERIFIED FIXED

(DevTools :: Inspector, defect, P1)

Description

[Calixte Denizet (:calixte)]

STR:

• open https://google-research.github.io/lingvo-lab/translatotron/
• right click on a player and "Inspect Element"
• expand audio control element in inspector
• right click on src and "Copy Link Address"
• try to paste somewhere => nothing has been copied

In using mozregression, I get:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=9c0bb955c19d90c1886b9af34d744eff5f110e52&tochange=e92ff56d2be21676b447c6fbb87b4c4479539bc9

Comment 1

[Pascal Chevrel:pascalc]

Fix-optional for 67, we might take a safe patch as a ridealong in a dot release.

Comment 2

[Razvan Caliman [:rcaliman]]

Attachment: Bug 1552275 - Fix Copy Link context menu in DevTools Inspector markup view. r=gl

• Fixes the references to the correct event handler & InspectorFront after a previous mass refactoring in Bug 1529364.
• Augments a test to ensure the clipboard content is correct executing the context menu action to copy a link.

Comment 3

[Razvan Caliman [:rcaliman]]

Thanks for discovering this :calixte!

I fixed the issue (a slight renaming mishap) and augmented one of our tests to check the clipboard.

I consider it a pretty safe patch. Once reviewed, we should aim to uplift this as soon as possible to 67 and 68. This is pretty important. "Copy Link Address" didn't work on any node type, not just <audio>.

Comment 4

[Razvan Caliman [:rcaliman]]

Try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=8ea377494fcd0da16f4f464d33701941fbf744d6

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d4c346b146a1
Fix Copy Link context menu in DevTools Inspector markup view. r=gl

Comment 6

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/d4c346b146a1

Comment 7

[Julien Cristau [:jcristau]]

Please request beta uplift when you get a chance. Thanks!

Comment 8

[Razvan Caliman [:rcaliman]]

Comment on attachment 9066009 [details]
Bug 1552275 - Fix Copy Link context menu in DevTools Inspector markup view. r=gl

Beta/Release Uplift Approval Request

• User impact if declined: Users are unable to use the context menu in the DevTools Inspector markup view to copy the href/src from <a>, <img>, <script>, <link>, <video> and <audio> tags.
  On click on the Copy Link Address option from the context menu invoked on the href/src attribute of a node, nothing is copied to the clipboard. Regressed by a change in bug 1529364.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Steps to verify:

• Navigate to any website
• Open DevTools Inspector and inspect any <a> or <img> tag in the markup view
• Right click on the href or src attribute of that tag
• Pick the "Copy Link Address" option from the context menu
• Paste the clipboard content into a file

Expected:
On paste, the clipboard content should hold the complete absolute URL (including domain) of the copied href or src attribute

• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The patch to fix the regression re-instates preexisting functionality that was accidentally disconnected. The patch fixes a typo in a method name and a mistaken reference. It updates a test to check that the behavior works as expected. No new user-facing functionality added.
• String changes made/needed:

Comment 9

[Razvan Caliman [:rcaliman]]

Has the fix been verified in Nightly?: Yes

I left that bank in the form, but it still showed up as a "Yes".
Clarification: I did test in Nightly and the fix works as expected, but still needs a formal check by QA as requested with the qe-verify+ flag by :jcristau

Comment 10

[Hani Yacoub, Desktop QA]

Verified as fixed on Firefox Nightly 69.0a1 (2019-05-23) on Windows 10 x 64, Mac OS X 10.14 and on Ubuntu 18.04 x64.

Comment 11

[Julien Cristau [:jcristau]]

Comment on attachment 9066009 [details]
Bug 1552275 - Fix Copy Link context menu in DevTools Inspector markup view. r=gl

devtools regression fix, approved for 68.0b5

Comment 12

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/releases/mozilla-beta/rev/baf9be06329b

Comment 13

[Hani Yacoub, Desktop QA]

Verified as fixed on Firefox 68.0b5 on Windows 10 x 64, Mac OS X 10.14 and on Ubuntu 18.04 x64.

Comment 15

[Pascal Chevrel:pascalc]

Comment on attachment 9066009 [details]
Bug 1552275 - Fix Copy Link context menu in DevTools Inspector markup view. r=gl

P1 for devtools, has tests, uplift verified on beta and had some bake time there with no reported regression, uplift approved for 67.0.2, thanks.

Comment 16

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/releases/mozilla-release/rev/5bb5e54bc396

Comment 17

[Razvan Caliman [:rcaliman]]

Thank you all for your help with uplifting this fix!

Comment 18

[Cristian Fogel [:cfogel]]

Adding QE+ for 67.0.2-build 2.

Comment 19

[Hani Yacoub, Desktop QA]

Verified as fixed on Firefox 67.0.2 on Windows 10 x 64, Mac OS X 10.14 and on Ubuntu 18.04 x64.