1552316 - Reduce reliance on FunctionBox's function() accessor

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P1)

Description

[Matthew Gaudet (he/him) [:mgaudet]]

To support a longer term goal of minimizing the GC interaction with the parser, one stepping-stone is the eventual removal of the JSFunction accessible via the FunctionBox.

That's a longer term goal, but we can already start reducing our reliance on that member.

Comment 1

[Matthew Gaudet (he/him) [:mgaudet]]

Attachment: Bug 1552316 - Remove unused FunctionScope::Data::zone() r?tcampbell

Comment 2

[Matthew Gaudet (he/him) [:mgaudet]]

Attachment: Bug 1552316 - Hoist some queries from function into FunctionBox r?tcampbell

Depends on D31529

Comment 3

[Matthew Gaudet (he/him) [:mgaudet]]

Attachment: Bug 1552316 - Hoist initLazyScript r?tcampbell

Depends on D31530

Comment 4

[Matthew Gaudet (he/him) [:mgaudet]]

Attachment: Bug 1552316 - Use FunctionBox in ModuleBuilder r?tcampbell

Depends on D31531

Comment 5

[Matthew Gaudet (he/him) [:mgaudet]]

Attachment: Bug 1552316 - Use FunctionBox in ASTSerializer::function r?tcampbell

Depends on D31532

Comment 6

[Matthew Gaudet (he/him) [:mgaudet]]

Attachment: Bug 1552316 - Use functionbox directly in ASMJS r?tcampbell

Depends on D31533

Comment 7

[Matthew Gaudet (he/him) [:mgaudet]]

Attachment: Bug 1552316 - Don't rely on functionbox in initWithEnclosingParseContext and initFiledInitializer r?tcampbell

Depends on D31534

Comment 8

[Matthew Gaudet (he/him) [:mgaudet]]

Attachment: Bug 1552316 - Don't rely on functionbox for initFromLazyFunction r?tcampbell

Depends on D31535

Comment 9

[Matthew Gaudet (he/him) [:mgaudet]]

Attachment: Bug 1552316 - Disconnect initWithEnclosingScope from functionbox r?tcampbell

Depends on D31536

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/043e6de8e69d
Remove unused FunctionScope::Data::zone() r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/2d814e205a86
Hoist some queries from function into FunctionBox r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/fb78510f1805
Use FunctionBox in ModuleBuilder r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/8e11986fdfd9
Use FunctionBox in ASTSerializer::function r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/da19f9f642fb
Use functionbox directly in ASMJS r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/3f5d50173ba4
Don't rely on functionbox in initWithEnclosingParseContext and initFiledInitializer r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/80dfbfe943a1
Don't rely on functionbox for initFromLazyFunction r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/86e4c72840f2
Disconnect initWithEnclosingScope from functionbox r=tcampbell

Comment 11

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/043e6de8e69d
https://hg.mozilla.org/mozilla-central/rev/2d814e205a86
https://hg.mozilla.org/mozilla-central/rev/fb78510f1805
https://hg.mozilla.org/mozilla-central/rev/8e11986fdfd9
https://hg.mozilla.org/mozilla-central/rev/da19f9f642fb
https://hg.mozilla.org/mozilla-central/rev/3f5d50173ba4
https://hg.mozilla.org/mozilla-central/rev/80dfbfe943a1
https://hg.mozilla.org/mozilla-central/rev/86e4c72840f2

Comment 12

[Matthew Gaudet (he/him) [:mgaudet]]

Attachment: Bug 1552316 - Correct merge resolution error r?tcampbell

Depends on D36814

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b8f248643eef
Correct merge resolution error r=tcampbell

Comment 14

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/b8f248643eef