155235 - Silence GCC3 deprecated header warnings.

Status: VERIFIED WONTFIX

(SeaMonkey :: Build Config, defect)

Description

[Dan Rosen]

Using GCC3 (a 3.1 cross-compiler for arm-linux), I get tons of warnings:

g++-v3/backward/backward_warning.h:32:2: warning: #warning This file includes at
least one deprecated or antiquated header. Please consider using one of the 32
headers found in section 17.4.1.2 of the C++ standard. Examples include
substituting the <X> header for the <X.h> header for C++ includes, or <sstream>
instead of the deprecated header <strstream.h>. To disable this warning use
-Wno-deprecated.

Probably the easiest thing to do would be simply add -Wno-deprecated, since I
doubt we can successfully convert our includes on most platforms.

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

-Wno-deprecated might silence warnings that we do want, though.

Comment 2

[Dan Rosen]

True... One (probably painful) alternative might be to macro-ize C++ includes.
For example:

  NS_INCLUDE(sstream)

would expand to

  #include <sstream>

on conformant compilers, and

  #include <strstream.h>

on non-conformant ones. Besides the implementation trouble of programming these
macros correctly, the two problems I see with this are that (1) it's a
far-reaching change that would almost certainly break ports for a few weeks, and
(2) it's yet another level of indirection that mozilla hackers would have to get
used to, and likely screw up more often than not.

Comment 3

[Dan Rosen]

Actually, it seems like most -- if not all -- of these warnings are coming from
nsBufferHandleUtils.h, which #includes <new.h>. Perhaps it's suffice to fix that
one spot...?

Comment 4

[hacker formerly known as [e-mail]]

> Probably the easiest thing to do would be simply add -Wno-deprecated, since I
> doubt we can successfully convert our includes on most platforms.

Why not? If the standard says that we should be using <foo> instead of <foo.h>,
then we should switch and make exceptions as necessary for the dwindling
non-comformant platforms. 

Comment 5

[Jon Granrose]

verified wontfix.