Closed Bug 1552355 Opened 3 months ago Closed 3 months ago

Port bug 1551782: Remove now-unused nsCOMArray::Forget and nsCOMArray::Adopt methods

Categories

(MailNews Core :: General, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 68.0

People

(Reporter: jorgk, Assigned: jorgk)

Details

Attachments

(1 file)

dist/include/msgIStructuredHeaders.h(75,11): error: no member named 'Adopt' in 'nsCOMArray<msgIAddressObject>'

Busted at midnight. Boris, is there a replacement? I haven't looked.

https://searchfox.org/comm-central/rev/1372614ee89d4a6b62ec047d69b4918e09f0432a/mailnews/mime/public/msgIStructuredHeaders.idl#127

Flags: needinfo?(bzbarsky)

Looks like this will work:

    // retval.Adopt(addresses, length);
    retval.Clear();
    retval.AppendElements(addresses, length);
    free(addresses);

First reviewer wins. Looks like we can hand-roll the function until we switch the interface.

Assignee: nobody → jorgk
Status: NEW → ASSIGNED
Attachment #9065550 - Flags: review?(mkmelin+mozilla)
Attachment #9065550 - Flags: review?(geoff)
Attachment #9065550 - Flags: review?(benc)

Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/d05d70ad9d05
Port bug 1551782: Hand-roll removed nsCOMArray::Adopt(). rs=bustage-fix

Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 68.0

Boris, is there a replacement?

No, sorry. I think I searched for Forget uses in comm-central before I realized I could remove Adopt too, and forgot to check for that one... :(

Flags: needinfo?(bzbarsky)
Comment on attachment 9065550 [details] [diff] [review]
1552355-Adopt.patch

Review of attachment 9065550 [details] [diff] [review]:
-----------------------------------------------------------------

Is there a bug to convert the interface and get rid of this?
Attachment #9065550 - Flags: review?(mkmelin+mozilla)
Attachment #9065550 - Flags: review?(geoff)
Attachment #9065550 - Flags: review?(benc)
Attachment #9065550 - Flags: review+

Yes, that's part of bug 1551704. msgIStructuredHeaders.idl shows up in the 2nd search in bug 1551704 comment #3. There's a lot to do.

You need to log in before you can comment on or make changes to this bug.