1552355 - Port bug 1551782: Remove now-unused nsCOMArray::Forget and nsCOMArray::Adopt methods

Status: RESOLVED FIXED

(MailNews Core :: General, task)

Description

[Jorg K (CEST = GMT+2)]

dist/include/msgIStructuredHeaders.h(75,11): error: no member named 'Adopt' in 'nsCOMArray<msgIAddressObject>'

Busted at midnight. Boris, is there a replacement? I haven't looked.

https://searchfox.org/comm-central/rev/1372614ee89d4a6b62ec047d69b4918e09f0432a/mailnews/mime/public/msgIStructuredHeaders.idl#127

Comment 1

[Jorg K (CEST = GMT+2)]

Also these ones:
https://searchfox.org/comm-central/search?q=retval.Adopt(addresses%2C+length)%3B&case=false&regexp=false&path=

Comment 2

[Jorg K (CEST = GMT+2)]

Looks like this will work:

    // retval.Adopt(addresses, length);
    retval.Clear();
    retval.AppendElements(addresses, length);
    free(addresses);

Comment 3

[Jorg K (CEST = GMT+2)]

Attachment: 1552355-Adopt.patch

First reviewer wins. Looks like we can hand-roll the function until we switch the interface.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/d05d70ad9d05
Port bug 1551782: Hand-roll removed nsCOMArray::Adopt(). rs=bustage-fix

Comment 5

[Boris Zbarsky [:bzbarsky]]

Boris, is there a replacement?

No, sorry. I think I searched for Forget uses in comm-central before I realized I could remove Adopt too, and forgot to check for that one... :(

Comment 6

[Magnus Melin [:mkmelin]]

Comment on attachment 9065550 [details] [diff] [review]
1552355-Adopt.patch

Review of attachment 9065550 [details] [diff] [review]:
-----------------------------------------------------------------

Is there a bug to convert the interface and get rid of this?

Comment 7

[Jorg K (CEST = GMT+2)]

Yes, that's part of bug 1551704. msgIStructuredHeaders.idl shows up in the 2nd search in bug 1551704 comment #3. There's a lot to do.