1552420 - Mocha tests are failing

Status: RESOLVED FIXED

(DevTools :: Console, defect, P1)

Description

[Nicolas Chevobbe [:nchevobbe]]

Bug 1547084 introduced a call to pointPrecedes which is loaded with ChromeUtils, but ChromeUtils is not defined in mocha's context.

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1552420 - Add a mock for ChromeUtils in mocha tests. r=jdescottes.

This fixes the test failures.
We remove the requireHacker case for ChromeUtils,
since it's never required.

Comment 2

[Nicolas Chevobbe [:nchevobbe]]

TRY

Comment 3

[Nicolas Chevobbe [:nchevobbe]]

what's weird is that treeherder doesn't see this as a failing test: https://treeherder.mozilla.org/#/jobs?repo=try&revision=ad0b2910bfcabed093761a94fdb3aef08c6050a9&selectedJob=246993633 is green, but looking at the log https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=246993633&repo=try&lineNumber=135 , you can see the error.

Comment 4

[Julian Descottes [:jdescottes]]

(In reply to Nicolas Chevobbe [:nchevobbe] from comment #3)

what's weird is that treeherder doesn't see this as a failing test: https://treeherder.mozilla.org/#/jobs?repo=try&revision=ad0b2910bfcabed093761a94fdb3aef08c6050a9&selectedJob=246993633 is green, but looking at the log https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=246993633&repo=try&lineNumber=135 , you can see the error.

Yes, our try runner is a bit weak, as we are parsing the out/err log from Jest and Mocha and try to identify errors based on regexp.

I will try to improve this by using json base reporters.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5a1c37d11ebc
Add a mock for ChromeUtils in mocha tests. r=jdescottes.

Comment 6

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/5a1c37d11ebc