1552446 - Leverage Remote Settings attachments utils for intermediates

Status: RESOLVED FIXED

(Core :: Security: PSM, enhancement, P2)

Description

[Mathieu Leplatre [:leplatrem]]

In Bug 1501214 we shipped some utils to download attachments.

The intermediate preloads clients precedes it and a lot of code is duplicated between the two.

Some of the code could be rewritten to leverage the attachments utils. For example, something like that:

ChromeUtils.defineModuleGetter(this, "Downloader", "resource://services-settings/Attachments.jsm");

async updatePreloadedIntermediates() {
  const records = this.client.get({
    filters: {
      cert_import_complete: false,
    }
  });

  for (const record of records) {
    let localUri;
    try {
      localUri = await client.attachments.download(record);
    } catch (e) {
      if (e instanceof Downloader.DownloadError) {
        // download error ... 
        // Services.telemetry...
      } else if (e instanceof Downloader.ContentError) {
        // hash, length error ...
        // Services.telemetry...
      } else {
        // ...
      }
      continue;
    }

    // const buffer = await (await fetch(localUri)).arrayBuffer();
    // const bytes = new Uint8Array(buffer); 
    // const text = await (await fetch(localUri)).text();

  }
}

Comment 1

[Mathieu Leplatre [:leplatrem]]

Attachment: Bug 1552446 - Leverage Remote Settings attachments utils for intermediates

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:leplatrem, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8b5bcdecb7ad
Leverage Remote Settings attachments utils for intermediates r=glasserc,jcj

Comment 4

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/8b5bcdecb7ad