Stop printpreview_bug396024_helper.xul creating a print preview viewer in a normal document window

RESOLVED FIXED in Firefox 68

Status

()

defect
P2
normal
RESOLVED FIXED
Last month
Last month

People

(Reporter: jwatt, Assigned: jwatt)

Tracking

unspecified
mozilla68
Points:
---

Firefox Tracking Flags

(firefox68 fixed)

Details

Attachments

(1 attachment)

Assignee

Description

Last month

When smaug changed printpreview_bug396024_helper.xul in bug 487667 to use a separate window (iframe) for the static clone doc, it went unnoticed that the removal and appending of the element in test 'run4' actually inverted the order of the iframes. Since the functions printPreview() and exitprintpreview() are hardcoded to act on frames[1], that means that we subsequently in 'run5' initialize a print preview viewer in the iframe (docShell) that was being used to load the document we're testing previews of.

I would like to change nsPrintJob to have hard invariants about where the print preview doc viewer can be loaded, and loading it into an existing docShell should not be allowed. Hence the change to this test to avoid violating this invariant.

Comment 2

Last month
Pushed by jwatt@jwatt.org:
https://hg.mozilla.org/integration/mozilla-inbound/rev/930f0f51b681
Stop printpreview_bug396024_helper.xul creating a print preview viewer in a normal document window. r=bobowen

Comment 3

Last month
bugherder
Status: NEW → RESOLVED
Closed: Last month
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
You need to log in before you can comment on or make changes to this bug.