Closed Bug 1552506 Opened 6 years ago Closed 6 years ago

Raptor log entries with critical/error end up as INFO in Taskcluster logs

Categories

(Testing :: Raptor, defect)

Version 3
defect
Not set
major

Tracking

(Not tracked)

VERIFIED DUPLICATE of bug 1522604

People

(Reporter: whimboo, Unassigned)

Details

Here an example:

https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=247046608&repo=autoland&lineNumber=495-496

13:53:45 INFO - raptor-manifest abort: specified test name doesn't exist
13:53:45 INFO - raptor-main abort: no tests found

Whereby the source has:

https://searchfox.org/mozilla-central/rev/94c6b5f06d2464f6780a52f32e917d25ddc30d6b/testing/raptor/raptor/manifest.py#359

LOG.critical("abort: specified test name doesn't exist")

We should get this fixed as soon as possible for proper error reporting.

James, do you have an idea why this is happening? Not sure if it is a mozlog or mozharness issue.

Flags: needinfo?(james)

I think the problem is in the RaptorErrorList in mozharness:

https://searchfox.org/mozilla-central/rev/94c6b5f06d2464f6780a52f32e917d25ddc30d6b/testing/mozharness/mozharness/mozilla/testing/raptor.py#33-44

The above case is not covered. Also some entries like raptorError seem to be outdated, given that I cannot find anything like that under testing/raptor. Maybe it was just copy and pasted? Rob, can you remember given that you worked on bug 1455107?

Flags: needinfo?(james) → needinfo?(rwood)

Here another case:

https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=247010098&repo=mozilla-central&lineNumber=2188-2189

10:55:43 INFO - raptor-main TEST-UNEXPECTED-FAIL: test 'raptor-tp6m-ebay-kleinanzeigen-search-geckoview-cold' timed out loading test page: https://m.ebay-kleinanzeigen.de/s-anzeigen/auf-zeit-wg-berlin/zimmer/c199-l3331 pending metrics: fcp, fnb paint, dcf, load time
10:55:43 ERROR - Return code: 1

Yes, I think you're correct; this is mozharness parsing the logs and re-emitting them at the wrong level.

Yes definitely needs to be addressed. I believe this is the same issue as Bug 1522604 - Add proper support for LOG.error (which marauder is currently working on)? If you agree please close this as a duplicate, thanks!

Flags: needinfo?(rwood)

It would have been good if that other bug was mentioned in our last Raptor meeting. So I wouldn't have filed a dupe in the first place. But yes, lets continue on that.

Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → DUPLICATE

Verified duplicate

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.