Closed Bug 1552537 Opened 7 years ago Closed 7 years ago

[about:addons] Plugins are missing preferences link

Categories

(Toolkit :: Add-ons Manager, defect, P1)

Product:
Toolkit
Component:
Add-ons Manager
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla69
Tracking Flags:
Tracking Status
firefox68 --- verified
firefox69 --- verified

People

(Reporter: mstriemer, Assigned: mstriemer)

References

Details

Attachments

(2 files)

Bug 1552537 - Include preferences option for plugins r?kmag
47 bytes, text/x-phabricator-request
jcristau
: approval-mozilla-beta+
Details | Review
Bug1552537.gif
328.01 KB, image/gif
Details

The flash plugin has preferences but it is missing from the menu template. Add the preferences option to the template.

Pushed by mstriemer@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/fe4c28957f15 Include preferences option for plugins r=kmag

https://hg.mozilla.org/mozilla-central/rev/fe4c28957f15

Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox69: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla69

Did you need this change in 68?

Flags: needinfo?(mstriemer)
Attached image Bug1552537.gif —

I was able to reproduce this issue on Firefox 69.0a1 (20190522093426) under Win 7 64-bit.

This issue is verified as fixed on Firefox 69.0a1 (20190527095441) under Win 7 64-bit and Ubuntu 14.04 LTS 32-bit.

Please see the attached video.

Status: RESOLVED → VERIFIED
status-firefox69: fixed → verified

Comment on attachment 9065845 [details]
Bug 1552537 - Include preferences option for plugins r?kmag

Beta/Release Uplift Approval Request

  • User impact if declined: Flash settings cannot be modified in the HTML about:addons
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Verified on Nightly, has automated tests
  • String changes made/needed:
Flags: needinfo?(mstriemer)
Attachment #9065845 - Flags: approval-mozilla-beta?

Comment on attachment 9065845 [details]
Bug 1552537 - Include preferences option for plugins r?kmag

fix for new about:addons, approved for 68.0b7

Attachment #9065845 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

This issue is verified as fixed on Firefox 68.0b7 (20190603181408) under Win 7 64-bit and Ubuntu 14.04 LTS 32-bit.

status-firefox68: fixed → verified
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: