1552610 - Bookmarks toolbar menu closing doesn't behave like other menus

Status: NEW

(Firefox :: Bookmarks & History, defect, P5)

Description

[equeim]

Attachment: out.webm

User Agent: Mozilla/5.0 (X11; Fedora; Linux x86_64; rv:66.0) Gecko/20100101 Firefox/66.0

Steps to reproduce:

1. Add bookmarks button to toolbar
2. Click on it to open bookmarks menu
3. Click on hamburger/library/history toolbar button

Actual results:

Bookmarks menu closes, but another menu that you have clicked on doesn't open.

Expected results:

Bookmarks menu should close, and another menu should open, just like it happens with any other menu except of bookmarks.
E.g. when you open library menu and click on bookmarks menu, library closes and bookmarks menu opens. This happens in every case except when already open menu is bookmarks menu.
Video is in attachment.

Comment 1

[Gingerbread Man]

Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:66.0) Gecko/20100101 Firefox/66.0
20190507012018

Works for me. Setting platform to Linux.

Can you reproduce this in a brand new profile?
https://support.mozilla.com/kb/profile-manager-create-and-remove-firefox-profiles

Comment 2

[equeim]

I've reproduced it on a new profile. It seems that Windows is not affected though.

Comment 3

[equeim]

This may be related to the fact that Bookmarks menu has different _NET_WM_WINDOW_TYPE X11 property than other toolbar menus. For bookmarks it is _NET_WM_WINDOW_TYPE_POPUP_MENU, and for other menus it is _NET_WM_WINDOW_TYPE_UTILITY. It's also results in KWin showing fading animation for bookmarks menu, but not for other menus.

Comment 4

[Mark Banner (:standard8)]

I suspect this is because of how we're generating the menus. The bookmarks toolbar button is an old style button which has a popup defined within it directly in the xul. The other menus are generated via CustomizableUI/CustomizableWidgets.

Gijs, any ideas where the problem might be here, do we need to move the bookmarks toolbar button to be generated in the same way as CustomizableUI, or could there a simple attribute we could set here?

Comment 5

[:Gijs (out for now; he/him)]

All the toolbar button's panels are <panel>s, except the bookmarks menu button which is a <menupopup> . There's bug 978881 for aligning them.

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

The priority flag is not set for this bug.
:mak, could you have a look please?

For more information, please visit auto_nag documentation.