1552700 - Unclosable calendar conflict dialog blocks Thunderbird [SyntaxError: redeclaration of var cal][ReferenceError: onLoad is not defined] in calendar-conflicts-dialog.xul

Status: RESOLVED FIXED

(Calendar :: Dialogs, defect)

Description

[Memmie Lenglet]

Attachment: Capture d’écran 2019-05-19 à 15.39.12.png

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:67.0) Gecko/20100101 Firefox/67.0

Steps to reproduce:

Start Thunderbird with Lightning extension enabled

Actual results:

Unclosable blank modal apprears and block Thunderbird UI

Expected results:

The modal shouldn't be blank and should be closable (at least with "OK" or "cancel" buttons)

Comment 1

[Stefan Sitter [:ssitter]]

Attached image of browser console shows:

SyntaxError: redeclaration of var cal calendar-conflicts-dialog.xul:17

ReferenceError: onLoad is not defined calendar-conflicts-dialog.xul:1

Might be the same dialog as in Bug 1551860.

Comment 2

[Stefan Sitter [:ssitter]]

@Geoff: in Bug 1520643 https://hg.mozilla.org/comm-central/rev/4dbbf88b2d37d3347e73ba7c5f7c055d6d687994 you changed a lot of imports like
const { Services } = ChromeUtils.import... into
var { Services } = ChromeUtils.import...

Is this required for calendar code too? Could this be cause of error: redeclaration of var cal?

When looking at https://searchfox.org/comm-central/search?q=calUtils.jsm I see lot of "var { cal } = ChromeUtils.import" but still several "const { cal } = ChromeUtils.import".

Comment 3

[Geoff Lankow (:darktrojan)]

Yes, if the line in calendar-conflicts-dialog.xul was using var instead of const this problem would go away.

As a general rule I've been using const where I know the variable won't be declared again (such as in a JSM) and var everywhere else.

I don't think it's worth doing a mass change for the sake of it.

Comment 6

[Stefan Sitter [:ssitter]]

Confirm based on duplicates.

Comment 8

[Geoff Lankow (:darktrojan)]

Attachment: 1552700-const-cal-1.diff

Sorry that this sat for so long, I was under the impression somebody was working on it.

Comment 9

[James Rome]

This is now a critical bug. It occurred on 67.0b3, and reappeared every time I restarted TB as soon as I entered my password. I had to revert to the release version of TB. Not sure if a reboot will clear this since I can't do one now.

Comment 10

[Arthur K. (he/him)]

(In reply to James Rome from comment #9)

This is now a critical bug. It occurred on 67.0b3, and reappeared every time I restarted TB as soon as I entered my password. I had to revert to the release version of TB. Not sure if a reboot will clear this since I can't do one now.

I had this same OK dialogue box loop happen to me recently. I seemed to have fixed it in https://bugzilla.mozilla.org/show_bug.cgi?id=1541304#c8.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/3b41b90ba85a
Change two instances of "const { cal }" to "var { cal }" to fix "SyntaxError: redeclaration of var cal". r=philipp

Comment 12

[Jorg K (CEST = GMT+2)]

TB 68 beta / Cal 7.0:
https://hg.mozilla.org/releases/comm-beta/rev/6d9a6ca0eeb865f6ea555a50da6cb0724508a46e

Comment 13

[Arthur K. (he/him)]

(In reply to Arthur K. from comment #10)

(In reply to James Rome from comment #9)

This is now a critical bug. It occurred on 67.0b3, and reappeared every time I restarted TB as soon as I entered my password. I had to revert to the release version of TB. Not sure if a reboot will clear this since I can't do one now.

I had this same OK dialogue box loop happen to me recently. I seemed to have fixed it in https://bugzilla.mozilla.org/show_bug.cgi?id=1541304#c8.

Correction: https://bugzilla.mozilla.org/show_bug.cgi?id=1541304#c9.