Closed Bug 1552737 Opened 6 years ago Closed 5 years ago

Cranelift: Redundant stack-slot-to-stack-slot copy removal

Categories

(Core :: JavaScript: WebAssembly, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED

People

(Reporter: lth, Assigned: jseward)

References

Details

Attachments

(1 file)

Cranelift currently has a tendency to create redundant copies (self-copies) at some loop heads, when the source and target of a non-removed Copy instruction is assigned to the same location.

In the case where the location is on the stack this looks particularly insane, because it's a load from the location followed by a store to the location.

A simple tweak in the reloader should be able to deal with these copies and turn them into nops.

Blocks: 1552744
Summary: Cranelift: Redundant copy removal → Cranelift: Redundant stack-slot-to-stack-slot copy removal

Closing, since this has landed in Cranelift and probably in Spidermonkey for a while.

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: