Closed Bug 1552822 Opened 5 years ago Closed 5 years ago

Raptor YouTube playback performance documentation

Categories

(Testing :: Raptor, defect, P1)

defect

Tracking

(firefox69 fixed)

RESOLVED FIXED
mozilla69
Tracking Status
firefox69 --- fixed

People

(Reporter: whimboo, Assigned: whimboo)

References

(Blocks 1 open bug)

Details

This bug covers the necessary work to get the recently added YouTube playback performance tests documented.

Most likely everything should be added to:
https://wiki.mozilla.org/Performance_sheriffing/Raptor

Rob, where should I document the handling with the external test page? Should it also go into the same page, or shall I create a new sub page for the particular test suite?

Flags: needinfo?(rwood)

(In reply to Henrik Skupin (:whimboo) [⌚️UTC+2] from comment #0)

This bug covers the necessary work to get the recently added YouTube playback performance tests documented.

Most likely everything should be added to:
https://wiki.mozilla.org/Performance_sheriffing/Raptor

Rob, where should I document the handling with the external test page? Should it also go into the same page, or shall I create a new sub page for the particular test suite?

I'd suggest adding a section under the benchmark tests list [0] but if you want to create a sub page and just add a link there to it that works for me, thanks!

[0] https://wiki.mozilla.org/Performance_sheriffing/Raptor#Benchmark_Tests_2

Flags: needinfo?(rwood)
Priority: -- → P2
Assignee: nobody → hskupin
Status: NEW → ASSIGNED
Priority: P2 → P1

Rob, can you please check the content of those newly added docs? In case something is unclear please let me know.

One question through, where do you want to see the documentation for handling the Performance playback test suite as mirrored at https://github.com/mozilla/perf-youtube-playback/? Should it be in its wiki, or also on the Wiki?

Flags: needinfo?(rwood)

(In reply to Henrik Skupin (:whimboo) [⌚️UTC+2] from comment #3)

Rob, can you please check the content of those newly added docs? In case something is unclear please let me know.

One question through, where do you want to see the documentation for handling the Performance playback test suite as mirrored at https://github.com/mozilla/perf-youtube-playback/? Should it be in its wiki, or also on the Wiki?

Thanks for the documentation, it looks great (I added the command line for running on GVE). If I'm understanding your question correctly, I think further details about the playback suite itself are fine inside it's own wiki at https://github.com/mozilla/perf-youtube-playback/, since you've linked to there in the Raptor wiki already anyway. Thanks again, the documentation will be very useful.

Flags: needinfo?(rwood)

I added the docs for updating the YouTube test suite:
https://github.com/mozilla/perf-youtube-playback/wiki

If there is something missing please add. Otherwise I call this bug fixed.

Flags: needinfo?(rwood)
Flags: needinfo?(dave.hunt)

(In reply to Henrik Skupin (:whimboo) [⌚️UTC+2] from comment #5)

I added the docs for updating the YouTube test suite:
https://github.com/mozilla/perf-youtube-playback/wiki

If there is something missing please add. Otherwise I call this bug fixed.

Looks great and very helpful, thanks!

Flags: needinfo?(rwood)

I will leave the needinfo for Dave for a post-check, but mark it as fixed now. Thanks!

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla69

The documentation looks good, thanks Henrik. We should have a contact for all perf tests, and I notice that this doesn't. Do either of you have a suggestion for someone who can help us to understand and investigate regressions for this test? Perhaps someone from the graphics team would be willing to put their name down?

Flags: needinfo?(rwood)
Flags: needinfo?(hskupin)
Flags: needinfo?(dave.hunt)

The primary contact should be Arnold and Alexandru, right? Not sure if it makes sense to add media folks here. Based on the regression someone else might be the contact, so maybe leave it up for SV whom to contact?

Flags: needinfo?(hskupin)

If it was a specific developer whom asked to have this particular test put into production then I'd suggest that she/he be the primary contact along with one person from our team - that way we have the developer who may be interested in if the numbers regress, as well as a contact on our team for test/framework breakages. For the other tests I would suggest we do the same if possible.

Flags: needinfo?(rwood)
You need to log in before you can comment on or make changes to this bug.