Closed Bug 1552895 Opened 7 years ago Closed 7 years ago

[wpt-sync] Sync PR 16921 - PaymentHandler: Fix change-payment-method.https.html test

Categories

(Core :: DOM: Web Payments, defect, P4)

Product:
Core
Component:
DOM: Web Payments
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla69
Tracking Flags:
Tracking Status
firefox69 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync upstream error])

Sync web-platform-tests PR 16921 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/16921
Details from upstream follow.

Jinho Bang <jinho.bang@samsung.com> wrote:

PaymentHandler: Fix change-payment-method.https.html test

Before this patch, TypeError occurs due to the wrong order of test
scripts. The error causes test failure and shutting down but service
worker registration might be going on different thread. At that time,
the service worker might not register to a finish and might cause DB
errors internally. It might eventually cause a crash due to DCHECK.
So, this patch fixes the wrong order of test scripts. After this patch,
TypeError no longer occurs and we guarantee that service worker is
activated at least.

Bug: 964158
Change-Id: Id8ebe86de3c558e81aad732c6ef6b513647f6465

Reviewed-on: https://chromium-review.googlesource.com/1619531
WPT-Export-Revision: c9e36758f31301bfbeb8ca0884ed60c8ebbc2314

PR 16921 applied with additional changes from upstream: e9c531e24f89fd73495cd62ee1f579e9b83aa45e
Component: web-platform-tests → DOM: Web Payments
Product: Testing → Core
Failed to get results from try push
Pushed by james@hoppipolla.co.uk: https://hg.mozilla.org/integration/mozilla-inbound/rev/be0fe469b610 [wpt PR 16921] - PaymentHandler: Fix change-payment-method.https.html test, a=testonly

https://hg.mozilla.org/mozilla-central/rev/be0fe469b610

Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox69: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla69
Whiteboard: [wptsync downstream] → [wptsync upstream error]
You need to log in before you can comment on or make changes to this bug.