Closed Bug 155291 Opened 23 years ago Closed 23 years ago

RegExp properties should be DontEnum

Categories

(Core :: JavaScript Engine, defect)

defect
Not set
minor

Tracking

()

VERIFIED FIXED

People

(Reporter: rogerl, Assigned: rogerl)

References

Details

(Keywords: js1.5)

Attachments

(1 file, 1 obsolete file)

>for (i in /a/) print(i) source global ignoreCase lastIndex multiline These are supposed to be don't enum - 15.10.7.1 thru 15.10.7.5
Comment on attachment 89951 [details] [diff] [review] Test for undefined value as argv[0] D'oh. Wrong bug.
Attachment #89951 - Attachment is obsolete: true
Test suite: Testcase ecma_2/RegExp/regexp-enumerate-001.js failed Bug Number 339403 Failure messages were: r = new RegExp(); e = new Array(); for ( p in r ) { e[e.length] = { property:p, value:r[p] }; e.length = 0 FAILED! expected: 5
Blocks: 149801
cc'ing reviewers; adding js1.5 keyword; adding as dependency to bug 149801 -
Keywords: js1.5
Comment on attachment 89956 [details] [diff] [review] Remove enumerate flag from attribute. sr=brendan@mozilla.org. I don't think khanson or shaver are around just now (vacation and moving?), so maybe rginda will r= this. /be
Attachment #89956 - Flags: superreview+
Comment on attachment 89956 [details] [diff] [review] Remove enumerate flag from attribute. r=khanson. I am not on vacation, just working remotely.
Attachment #89956 - Flags: review+
Note rogerl is on vacation until July 8. I think we want this for the 1.0 branch, too, right?
Fixed in branch and trunk. /be
Status: NEW → RESOLVED
Closed: 23 years ago
Keywords: fixed1.0.1
Resolution: --- → FIXED
Verified FIXED. Testcase corrected: mozilla/js/tests/ecma_2/RegExp/regexp-enumerate-001.js This test now passes in the debug/optimized JS shells, and in the rhino/rhinoi shells, since Roger also made the fix there. Also fixed on MOZILLA_1_0_BRANCH; adding verified1.0.1 keyword -
Status: RESOLVED → VERIFIED
Keywords: verified1.0.1
Flags: testcase+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: