155291 - RegExp properties should be DontEnum

Status: VERIFIED FIXED

(Core :: JavaScript Engine, defect)

Description

[rogerl (gone)]

>for (i in /a/) print(i)
source
global
ignoreCase
lastIndex
multiline

These are supposed to be don't enum - 15.10.7.1 thru 15.10.7.5

Comment 1

[rogerl (gone)]

Attachment: Test for undefined value as argv[0]

Comment 2

[rogerl (gone)]

Comment on attachment 89951 [details] [diff] [review]
Test for undefined value as argv[0]

D'oh. Wrong bug.

Comment 3

[rogerl (gone)]

 Test suite:

   Testcase ecma_2/RegExp/regexp-enumerate-001.js failed Bug Number 339403
    Failure messages were:
    r = new RegExp(); e = new Array(); for ( p in r ) { e[e.length] = {
property:p, value:r[p] }; e.length = 0 FAILED! expected: 5

Comment 4

[rogerl (gone)]

Attachment: Remove enumerate flag from attribute.

Comment 5

[Phil Schwartau]

cc'ing reviewers; adding js1.5 keyword; adding as dependency to bug 149801 -

Comment 6

[Brendan Eich [:brendan]]

Comment on attachment 89956 [details] [diff] [review]
Remove enumerate flag from attribute.

sr=[e-mail].  I don't think khanson or shaver are around just now
(vacation and moving?), so maybe rginda will r= this.

/be

Comment 7

[Kenton Hanson (gone)]

Comment on attachment 89956 [details] [diff] [review]
Remove enumerate flag from attribute.

r=khanson.

I am not on vacation, just working remotely.

Comment 8

[Phil Schwartau]

Note rogerl is on vacation until July 8. I think we want this 
for the 1.0 branch, too, right?

Comment 9

[Brendan Eich [:brendan]]

Fixed in branch and trunk.

/be

Comment 10

[Phil Schwartau]

Verified FIXED. Testcase corrected:

  mozilla/js/tests/ecma_2/RegExp/regexp-enumerate-001.js


This test now passes in the debug/optimized JS shells, and in
the rhino/rhinoi shells, since Roger also made the fix there.
Also fixed on MOZILLA_1_0_BRANCH; adding verified1.0.1 keyword -