1552976 - stop correlations tab jumping

Status: RESOLVED FIXED

(Socorro :: Webapp, defect, P3)

Description

[Will Kahn-Greene [:willkg] ET needinfo? me]

When the report view loads, the correlations tab is not visible. It only shows up after correlations load. At the time, I was responding to a bug where the report view shouldn't show a correlations tab for products that don't have correlations calculated for. Seemed reasonable.

However, I'm changing my mind and I think it's just awful for two reasons:

1. we shouldn't be hiding parts of the interface for some things and not others--it's better to instead show a "N/A" kind of message; we do this now with permissions issues
2. the fact that it's not there and then suddenly appears causing the "Reprocess" tab to jump to the right is irritating as all hell and keeps biting me

Anyhow, this bug covers changing the correlations tab so it's always visible and for products that don't have correlations, we should display a "N/A" kind of message with wording to be determined.

Comment 1

[Will Kahn-Greene [:willkg] ET needinfo? me]

This affects me, but it's not urgent, so I'm making it a P3.

Comment 2

[Will Kahn-Greene [:willkg] ET needinfo? me]

This is super irritating. Grabbing to fix it now.

Comment 3

[Will Kahn-Greene [:willkg] ET needinfo? me]

Attachment: pr 5078: bug 1552976: fix correlations tab

Comment 4

[Will Kahn-Greene [:willkg] ET needinfo? me]

willkg merged PR #5078: "bug 1552976: fix correlations tab" in 6438212.

Comment 5

[Will Kahn-Greene [:willkg] ET needinfo? me]

Deployed just now in bug #1608229.

Thank goodness this hellish nightmare is over.