1553136 - Crash in [@ mozilla::layers::UiCompositorControllerChild::ProcessingError]

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect, P3)

Description

[David Bolter [:davidb] (NeedInfo me for attention)]

This bug is for crash report bp-210997c4-a0a8-4693-abf0-f9a9b0190521.

Top 10 frames of crashing thread:

0 libxul.so mozilla::layers::UiCompositorControllerChild::ProcessingError gfx/layers/ipc/UiCompositorControllerChild.cpp:227
1 libxul.so mozilla::ipc::MessageChannel::MaybeHandleError ipc/glue/MessageChannel.cpp:2502
2 libxul.so mozilla::ipc::MessageChannel::DispatchMessage ipc/glue/MessageChannel.cpp:2153
3 libxul.so mozilla::ipc::MessageChannel::MessageTask::Run ipc/glue/MessageChannel.cpp:1968
4 libxul.so long long mozilla::jni::NativeStub<mozilla::java::GeckoThread::RunUiThreadCallback_t, GeckoThreadSupport, mozilla::jni::Args<> >::Wrap<&GeckoThreadSupport::RunUiThreadCallback> widget/android/jni/Natives.h:689
5 base.odex base.odex@0x43d4f 
6 dalvik-LinearAlloc (deleted) dalvik-LinearAlloc @0x641a 
7 dalvik-main space (region space) (deleted) dalvik-main space @0x81406 
8 dalvik-main space (region space) (deleted) dalvik-main space @0x25caeee 
9 dalvik-main space (region space) (deleted) dalvik-main space @0x260104e 

More here: https://crash-stats.mozilla.com/signature/?product=Fenix&signature=mozilla%3A%3Alayers%3A%3AUiCompositorControllerChild%3A%3AProcessingError

Comment 1

[Ryan Hunt [:rhunt]]

This is hitting an assert in UiCompositorControllerChild for a IPDL error.

Randall, you're the author of the assert, do you know if we need to be crashing for this?

Comment 2

[Randall Barker [:rbarker]]

It was copied from here:
https://searchfox.org/mozilla-central/rev/4606c7974a68cab416c038acaedcae49eed93822/gfx/layers/ipc/CompositorManagerChild.cpp#235

Which seems to have changed so it can probably be updated to match.

Comment 3

[Ryan Hunt [:rhunt]]

I'll try and take this.

Comment 4

[Ryan Hunt [:rhunt]]

Attachment: Bug 1553136 - Match CompositorManagerChild::ProcessingError behavior in UiCompositorControllerChild. r?rbarker

This will make this site only crash in debug, nightly, or dev edition builds.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cab2c0eaec74
Match CompositorManagerChild::ProcessingError behavior in UiCompositorControllerChild. r=rbarker

Comment 6

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/cab2c0eaec74

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Do we need to backport this for Beta for GV68?

Comment 8

[Ryan Hunt [:rhunt]]

I don't think this is an important fix? There's only a couple crashes with it. It would be a pretty easy uplift though (just a couple lines), so I'm not sure.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Any thoughts on this, Chris?

Comment 10

[Chris Peterson [:cpeterson]]

(In reply to Ryan VanderMeulen [:RyanVM] from comment #9)

Any thoughts on this, Chris?

The crash volume is very low, so I don't think we need to uplift to GV 68 Beta.