1553154 - Perma dom/animation/test/chrome/test_animation_observers_async.html | Animations automatically removed are reported - Animations automatically removed are reported: promise_test when Gecko 69 merges to Beta on 19-07-01

Status: VERIFIED FIXED

(Core :: DOM: Animation, defect)

Comment 1

[Alexandru Michis [:malexandru]]

Central as beta: https://treeherder.mozilla.org/#/jobs?repo=try&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel%2Crunnable&revision=bbb8dd2e205872ea5ad31f5e8daca809e2006a42&selectedJob=247541386

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=247541386&repo=try&lineNumber=56178

Failure snippet:
13:18:24 INFO - TEST-START | dom/animation/test/chrome/test_animation_observers_async.html
13:18:24 INFO - GECKO(3440) | ++DOMWINDOW == 50 (1CBDB400) [pid = 2012] [serial = 50] [outer = 1CB4FEE0]
13:18:24 INFO - TEST-INFO | started process screenshot
13:18:24 INFO - TEST-INFO | screenshot: exit 0
13:18:24 INFO - Buffered messages logged at 13:18:24
13:18:24 INFO - TEST-PASS | dom/animation/test/chrome/test_animation_observers_async.html | Test chrome-only MutationObserver animation notifications (async tests) - Test chrome-only MutationObserver animation notifications (async tests): Elided 1 passes or known failures.
13:18:24 INFO - Buffered messages finished
13:18:24 INFO - TEST-UNEXPECTED-FAIL | dom/animation/test/chrome/test_animation_observers_async.html | Animations automatically removed are reported - Animations automatically removed are reported: promise_test: Unhandled rejection with value: object "NotSupportedError: Animation to or from an underlying val..."
13:18:24 INFO - GECKO(3440) | --DOCSHELL 10179000 == 15 [pid = 2012] [id = {9c9cbfff-2607-408b-a0ff-d99ffe573709}] [url = chrome://gfxsanity/content/sanityparent.html]
13:18:25 INFO - TEST-PASS | dom/animation/test/chrome/test_animation_observers_async.html | Test chrome-only MutationObserver animation notifications (async tests) - Test chrome-only MutationObserver animation notifications (async tests): Elided 13 passes or known failures.

Comment 2

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Attachment: Bug 1553154 - enable animation preferences for test_animation_observers_async.html. r=birtles

Comment 3

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=122dedd3b69303fe688c3033666a45604f5ef186

Comment 4

[Alexandru Michis [:malexandru]]

Central as early beta sim: https://treeherder.mozilla.org/#/jobs?repo=try&revision=515741fed29ee61d5181d8b87fbf3274333b017f&searchStr=%28c1%29

This patch seems to fix the current issue.

Comment 5

[Brian Birtles (:birtles)]

(In reply to Mihai Alexandru Michis [:malexandru] from comment #4)

Central as early beta sim: https://treeherder.mozilla.org/#/jobs?repo=try&revision=515741fed29ee61d5181d8b87fbf3274333b017f&searchStr=%28c1%29

This patch seems to fix the current issue.

As I mentioned in the review, it's not testing what it should be testing. It needs to enable the dom.animations-api.autoremove.enabled pref.

It should be just:

+SpecialPowers.pushPrefEnv(
+  {
+    set: [
+      ["dom.animations-api.autoremove.enabled", true],
+      ["dom.animations-api.implicit-keyframes.enabled", true],
+    ],
+  },
+  function() {
+    runTest();
+    done();
+  }
+);

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Just adding ["dom.animations-api.implicit-keyframes.enabled", true] is enough: https://treeherder.mozilla.org/#/jobs?repo=try&revision=98e33d4e4f73d5a1c40a5b5f77e05cffdc9599fa
Do you want it submitted just with that pref or both? Will you track why it works with just that one pref enabled?

Comment 7

[Brian Birtles (:birtles)]

(In reply to Sebastian Hengst [:aryx] (needinfo on intermittent or backout) from comment #6)

Just adding ["dom.animations-api.implicit-keyframes.enabled", true] is enough: https://treeherder.mozilla.org/#/jobs?repo=try&revision=98e33d4e4f73d5a1c40a5b5f77e05cffdc9599fa
Do you want it submitted just with that pref or both?

With both (otherwise we're not testing what we should be testing).

Will you track why it works with just that one pref enabled?

No, making this particular test fail for every possible invalid combination of prefs doesn't seem useful.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7d73f17d3c58
enable animation preferences for test_animation_observers_async.html. r=birtles

Comment 9

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/7d73f17d3c58

Comment 10

[Andreea Pavel [:apavel]]

No longer occurs in recent beta simulations.

Comment 11

[Intermittent Failures Robot]

3 failures in 4730 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• try: 3

Platform breakdown:

• linux64-shippable-qr: 1
• linux64-shippable: 1
• windows10-64-shippable: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1553154&startday=2019-05-20&endday=2019-05-26&tree=all