Change JavaScript includes to use type=module for about:logins
Categories
(Toolkit :: Password Manager, enhancement, P3)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox69 | --- | fixed |
People
(Reporter: jaws, Assigned: jaws)
References
Details
Attachments
(1 file)
Per bug 1551379, we can now use script[type=module] with the scripts for about:logins. This bug will track the work required to convert our usage from standalone scripts to using module scripts.
|
Assignee | |
Updated•5 years ago
|
|
|
Assignee | |
Comment 1•5 years ago
|
||
about:logins works with this patch, but mochitest-plain tests fail because they are unable to load the nested scripts using chrome: URIs. The chrome: URIs are required to load the scripts from about:logins, so we are stuck in a bit of a pickle as far as I can tell.
|
||
Updated•5 years ago
|
Pushed by jwein@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d003d1dd77b1 Import about:logins components as JS modules. r=MattN
|
||
Comment 3•5 years ago
|
||
Backed out for mochitest failures on test_login_filter.html
Backout link: https://hg.mozilla.org/integration/autoland/rev/acc70b479cf4394e2bd9a7dd42253579aa8d6ae1
Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=248265804&repo=autoland&lineNumber=1586
|
|
||
Comment 4•5 years ago
|
||
There were also bc failures on reflected-fluent-element.js
Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=248267483&repo=autoland&lineNumber=2871
Pushed by jwein@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/46ea01fa7357 Import about:logins components as JS modules. r=MattN
|
||
Comment 6•5 years ago
|
||
| bugherder | ||
Description
•