Closed Bug 1553234 Opened 7 years ago Closed 7 years ago

Add aria-expanded attribute to collapsible sections

Categories

(Firefox :: New Tab Page, enhancement, P1)

Product:
Firefox
Component:
New Tab Page
Type:
enhancement

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 69
Iteration:
69.1 - May 13 - 26
Tracking Flags:
Tracking Status
firefox69 --- verified

People

(Reporter: emcminn, Assigned: emcminn)

References

Details

(Keywords: access, github-merged)

Attachments

(1 file)

Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/5063
52 bytes, text/x-github-pull-request
Details | Review

Top-Sites/ Recommended by Pocket/ etc. sections should have an aria-expanded attribute that mirrors this.props.collapsed.

Priority: -- → P2
Blocks: 1554322

https://hg.mozilla.org/mozilla-central/rev/6dc17248fa2c

Status: NEW → RESOLVED
Iteration: --- → 69.1 - May 13 - 26
Closed: 7 years ago
status-firefox69: --- → fixed
Keywords: github-merged
Priority: P2 → P1
Resolution: --- → FIXED
Target Milestone: --- → Firefox 69
Assignee: nobody → emcminn

I have verified this issue with the latest Firefox Nightly (69.0a1 Build ID - 20190602221035) installed, on Windows 10 x64, Arch Linux and Mac 10.14.5. Now, the "aria-expanded" attribute is added to the "Top Sites", "Recommended by Pocket" and "Highlights" sections.

Status: RESOLVED → VERIFIED
status-firefox69: fixed → verified
Component: Activity Streams: Newtab → New Tab Page
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: