1553290 - SupportMenu policy isn't working in the hamburger menu

Status: VERIFIED FIXED

(Firefox :: Enterprise Policies, defect, P1)

Description

[Mike Kaply [:mkaply]]

The support menu policy is working in the dropdown menu but not in the hamburger menu.

Comment 1

[Mike Kaply [:mkaply]]

Attachment: Bug 1553290 - Get support menu href direct from policy.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/96402748b816
Get support menu href direct from policy. r=jaws

Comment 3

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/96402748b816

Comment 4

[Mike Kaply [:mkaply]]

Comment on attachment 9067135 [details]
Bug 1553290 - Get support menu href direct from policy.

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: Policy related
• User impact if declined: New policy (SupportMenu) won't work on 68.
• Fix Landed on Version: 69
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Automated test, policy only, on nightly for a while.
• String or UUID changes made by this patch:

Beta/Release Uplift Approval Request

• User impact if declined: New policy (SupportMenu) won't work on 68.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Automated test, policy only, on nightly for a while.
• String changes made/needed:

Comment 5

[Julien Cristau [:jcristau]]

Looks like there would have been ample time to test this while it was on nightly and uplift before the last minute, I'd rather not take this in rc2.

Comment 6

[Mike Kaply [:mkaply]]

It was just a miss on my part. I forgot to uplift.

Comment 7

[Emil Ghitta, QA [:emilghitta]]

This issue is verified fixed using Firefox 69.0b3 (BuildId:20190708182549) on Windows 10 64bit, macOS 10.15 and Ubuntu 18.04 64bit.

Comment 8

[Mike Kaply [:mkaply]]

jcristau, now that this has been/tested and verified, wanted to reask for esr/68. Tx.

Comment 9

[Julien Cristau [:jcristau]]

Comment on attachment 9067135 [details]
Bug 1553290 - Get support menu href direct from policy.

enterprise policy fix, approved for 68.0.1 and 60.1esr

Comment 10

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

(In reply to Julien Cristau [:jcristau] from comment #9)

approved for 68.0.1 and 60.1esr

Please clarify in which ESR versions that fix shall ship: 68.0.1esr, 68.1.0esr, 60.8.1esr, 60.9.0esr

Comment 11

[Mike Kaply [:mkaply]]

Any 68 ESRs, not the 60 ESR.

Is 68.1.0esr going to be shipped from the 68.0.1 esr branch?

Comment 12

[Julien Cristau [:jcristau]]

(In reply to Sebastian Hengst [:aryx] (needinfo on intermittent or backout) from comment #10)

(In reply to Julien Cristau [:jcristau] from comment #9)

approved for 68.0.1 and 60.1esr

Please clarify in which ESR versions that fix shall ship: 68.0.1esr, 68.1.0esr, 60.8.1esr, 60.9.0esr

Sorry, I meant 68.1esr.

(In reply to Mike Kaply [:mkaply] from comment #11)

Any 68 ESRs, not the 60 ESR.

Is 68.1.0esr going to be shipped from the 68.0.1 esr branch?

No.

Comment 13

[Julien Cristau [:jcristau]]

https://hg.mozilla.org/releases/mozilla-release/rev/b5cbb0c4e2c4

Comment 14

[Ryan VanderMeulen [:RyanVM]]

Per discussion with jcristau, we're uplifting this to 68.0.1esr also to maintain parity with the non-ESR 68.0.1 release and hopefully avoid some confusion.

Comment 15

[Ryan VanderMeulen [:RyanVM]]

default (68.1esr): https://hg.mozilla.org/releases/mozilla-esr68/rev/c2d721bb99e101b6b02515f2ac79fd50c1b7ccd1
FIREFOX_ESR_68_0_X_RELBRANCH (68.0.1esr): https://hg.mozilla.org/releases/mozilla-esr68/rev/bac1bf00d47cea59f0a8f96c54005f7abae43310