1553311 - Perma browser_browser_languages_subdialog.js failures when Gecko version increases to 70 on 2019-07-08

Status: VERIFIED FIXED

(Firefox :: Settings UI, defect, P1)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Version increase simulation: https://treeherder.mozilla.org/#/jobs?repo=try&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel%2Crunnable&revision=1a7d27e9716b885fa3e1a697d896781f76d0c6fb&searchStr=browser-chrome&selectedJob=247550751

Failure log (second failing test): https://treeherder.mozilla.org/logviewer.html#?job_id=247550751&repo=try

TEST-UNEXPECTED-FAIL | browser/components/preferences/in-content/tests/browser_browser_languages_subdialog.js | The events are recorded correctly - [] deepEqual [["manage","main","16044"],["search","dialog","16044"],["add","dialog","16044",{"installId":6}],["cancel","dialog","16044"]] - JS frame :: chrome://mochitests/content/browser/browser/components/preferences/in-content/tests/browser_browser_languages_subdialog.js :: assertTelemetryRecorde

Fails because intl.ui.browserLanguage expires in Gecko 70: https://searchfox.org/mozilla-central/rev/6c9f60f8cc064a1005cd8141ecd526578ae9da7a/toolkit/components/telemetry/Events.yaml#1152

Comment 1

[Mark Striemer [:mstriemer]]

Attachment: data-review.txt

Comment 2

[Chris H-C :chutten]

Comment on attachment 9068567 [details]
data-review.txt

DATA COLLECTION REVIEW RESPONSE:

    Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate?

Yes. This collection is Telemetry so is documented in its definitions file [Events.yaml](https://hg.mozilla.org/mozilla-central/file/tip/toolkit/components/telemetry/Events.yaml) and the [Probe Dictionary](https://telemetry.mozilla.org/probe-dictionary/).

    Is there a control mechanism that allows the user to turn the data collection on and off?

Yes. This collection is Telemetry so can be controlled through Firefox's Preferences.

    If the request is for permanent data collection, is there someone who will monitor the data over time?

No. This collection will expire in six more months (I presume in Firefox 75).

    Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 2, Interaction.

    Is the data collection request for default-on or default-off?

Default on for all channels.

    Does the instrumentation include the addition of any new identifiers?

No.

    Is the data collection covered by the existing Firefox privacy notice?

Yes.

    Does there need to be a check-in in the future to determine whether to renew the data?

Yes. :mstriemer is responsible for renewing or removing the collection before it expires in Firefox 75.

---
Result: datareview+

Clear to renew to 75.

Comment 3

[Mark Striemer [:mstriemer]]

Attachment: Bug 1553311 - Renew browser languages telemetry until 75 r?janerik

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fb13459f32e4
Renew browser languages telemetry until 75 r=janerik

Comment 5

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/fb13459f32e4

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Verified fixed by latest version increase simulation: https://treeherder.mozilla.org/#/jobs?repo=try&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel%2Crunnable&revision=b18f0867fe28ed0b62789869e614fdccbb7965f8