1553317 - Improve error message on missing method implementation

Status: RESOLVED FIXED

(Remote Protocol :: Agent, enhancement, P1)

Description

[Andreas Tolfsen ❲:ato❳]

We fail with this rather omnious message when we haven’t implemented a CDP method:

Error: Protocol error (Target.createBrowserContext): TypeError: inst[command] is not a function:

We should improve that so debugging the code isn’t necessary.

Comment 1

[Andreas Tolfsen ❲:ato❳]

Attachment: bug 1553317: remote: improve error message on missing method;

We return with this rather omnious message when we are missing the
implementation of a CDP method:

Error: Protocol error (Target.createBrowserContext): TypeError: inst[command] is not a function:

This patch improves the error message so that debugging is not
necessary to find out which domain or command is missing.

Ideally Session.jsm and ContentProcessSession.jsm would share the
same execute() function (there's really not reason they don't),
but that involves more work.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f3d44dbce7e3
remote: improve error message on missing method; r=remote-protocol-reviewers,ochameau

Comment 3

[Cristian Brindusan [:cbrindusan]]

Backed out changeset f3d44dbce7e3 (Bug 1553317) for bc failures at browser_parsable_css.js.

Backout: https://hg.mozilla.org/integration/autoland/rev/df412702ed3112bb5d6c70ca728f97a224c89549

Push that started the failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception&revision=f3d44dbce7e3d1b529ce37b21a4d7471a918edd4&selectedJob=248549410

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=248549410&repo=autoland&lineNumber=2078

Comment 4

[Andreas Tolfsen ❲:ato❳]

Pretty sure this is an intermittent. Retriggering to find out.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/34cc442a91cb
remote: improve error message on missing method; r=remote-protocol-reviewers,ochameau CLOSED TREE

Comment 6

[Bogdan Tara[:bogdan_tara | bogdant]]

:ato we've re-landed your patch. Sorry.

Comment 7

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/34cc442a91cb

Comment 8

[Andreas Tolfsen ❲:ato❳]

Oh I didn’t expect the follow up service of re-landing it for me here, but thanks!