Remove nsIPrintSettings.printFrameTypeUsage

RESOLVED FIXED in Firefox 69

Status

()

task
P2
normal
RESOLVED FIXED
2 months ago
2 months ago

People

(Reporter: jwatt, Assigned: jwatt)

Tracking

unspecified
mozilla69
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox69 fixed)

Details

Attachments

(1 attachment)

printFrameTypeUsage can have two values:

  • kUseInternalDefault
  • kUseSettingWhenPossible

We set these values in exactly one place in the code each. We set kUseInternalDefault as the initial value for nsPrintSettings::mPrintFrameTypeUsage, and we set kUseSettingWhenPossible as a default value of a local variable that is used as an outparam for nsPrintSettings::GetPrintFrameTypeUsage, which overwrites that local variable with the value of nsPrintSettings::mPrintFrameTypeUsage. In other words, the one place where we assign kUseSettingWhenPossible has no affect. Essentially kUseSettingWhenPossible is unused, and we always take the kUseInternalDefault codepaths.

We should get rid of all this code and just hardcode the kUseInternalDefault path that we always take. (Especially in light of bug 1552785 where we're going to more extensively hardcode the behavior anyway.)

Type: defect → task
Pushed by jwatt@jwatt.org:
https://hg.mozilla.org/integration/mozilla-inbound/rev/919893dc7365
Remove nsIPrintSettings.printFrameTypeUsage. r=bobowen
Status: NEW → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla69
You need to log in before you can comment on or make changes to this bug.