1553324 - Remove nsIPrintSettings.printFrameTypeUsage

Status: RESOLVED FIXED

(Core :: Printing: Setup, task, P2)

Description

[Jonathan Watt [:jwatt]]

printFrameTypeUsage can have two values:

• kUseInternalDefault
• kUseSettingWhenPossible

We set these values in exactly one place in the code each. We set kUseInternalDefault as the initial value for nsPrintSettings::mPrintFrameTypeUsage, and we set kUseSettingWhenPossible as a default value of a local variable that is used as an outparam for nsPrintSettings::GetPrintFrameTypeUsage, which overwrites that local variable with the value of nsPrintSettings::mPrintFrameTypeUsage. In other words, the one place where we assign kUseSettingWhenPossible has no affect. Essentially kUseSettingWhenPossible is unused, and we always take the kUseInternalDefault codepaths.

We should get rid of all this code and just hardcode the kUseInternalDefault path that we always take. (Especially in light of bug 1552785 where we're going to more extensively hardcode the behavior anyway.)

Comment 1

[Jonathan Watt [:jwatt]]

Attachment: Bug 1553324. Remove nsIPrintSettings.printFrameTypeUsage. r=bobowen

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/919893dc7365
Remove nsIPrintSettings.printFrameTypeUsage. r=bobowen

Comment 3

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/919893dc7365