1553331 - Cannot remove site from top links on home screen

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: Awesomescreen, enhancement, P2)

Description

[JR Conlin [:jrconlin,:jconlin]]

Trying to remove a link from Top Sites fails. (See video at https://photos.app.goo.gl/CtYD8onBPP9odhkf9) Link URL goes to https://www.mlb.com/giants

I'm not sure what's special about that URL. It's not pinned, nor is it a saved bookmark.

Comment 1

[Eliza Balazs]

Hi and thank you for the report!

I tested this on Nightly 68.0a1 (2019-05-17) with Nexus 6P (Android 8.1.0) and I could reproduce the issue following the steps:

1. Go to https://www.mlb.com/giants and navigate on the page;
2. Go to about:home and delete from the Top Sites list the previous mentioned page;

Expected result:
The page is deleted from the Top Sites list.

Actual result:
The page is not deleted from the Top Sites list.

Notes:

• I have noticed that you have to press the "Delete from History" the same number of times that you navigate in the page.
• On Beta and on Release, the page appears in the Top Sites list the same number of times that you navigate in the page.
• This is also reproducible on ftp.mozilla.org/pub/mobile/candidates.
• Video: https://drive.google.com/file/d/13nU8pY9Ld7vIx1CIPI2jjVcE7KVMJ2bU/view

The regression is:

Last good revision: 387e71baf2efedfb90a287a378dc2ed45a1161cd
First bad revision: 8e592445e44255edb05d4d21bd3ecbda21a1ede1

Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=387e71baf2efedfb90a287a378dc2ed45a1161cd&tochange=8e592445e44255edb05d4d21bd3ecbda21a1ede1

Petru: It seems that Bug 1506231 introduced this issue, can you please have a look? Thanks!

Comment 2

[Petru-Mugurel Lingurar [:petru]]

This is the expected behavior. There's nothing special about mlb.com. Same happens with any other domain with more pages accessed by the user.

The feature works (mainly) by putting in front of the user the most visited URLs.
In this case from what I understand you probably accessed 4 different pages on that domain. Each counts as a separate entry in our db and each entry will have it's own number of visits counted which allows sorting them and showing only a limited subset of the total entries.

IMO this is not a regression because as Eliza said, before my patch, each visited page (even on the same domain) would appear in that TopSites list and in your case you would still have to press remove 4 times to actually remove all mlb.com entries.
My patch just grouped together all pages for the same domain to allow for other domain to appear in that list. If you remove the most visited page on a domain, the second most visited would be shown and so on.

Don't really know if we should drop all pages from a domain. Some might be bookmarks, some pinned, others just history entries.
Asking for Devin's input here.

Comment 3

[Devin Reams]

I agree with Petru's assessment and will keep this open to consider but likely not to be addressed, but worth considering in the new Firefox (Preview) application separately.

Comment 4

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.